reviewdog [clippy] report
reported by reviewdog 🐶
Findings (20)
framework/meta/src/template/template_adjuster.rs|79 col 50| warning: writing &String
instead of &str
involves a new object where a slice will do
--> framework/meta/src/template/template_adjuster.rs:79:50
|
79 | fn rename_trait_to(&self, new_template_name: &String) {
| ^^^^^^^ help: change this to: &str
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
= note: #[warn(clippy::ptr_arg)]
on by default
framework/meta/src/template/template_adjuster.rs|121 col 41| warning: this expression creates a reference which is immediately dereferenced by the compiler
--> framework/meta/src/template/template_adjuster.rs:121:41
|
121 | &self.get_dependecy(&new_template_name),
| ^^^^^^^^^^^^^^^^^^ help: change this to: new_template_name
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
= note: #[warn(clippy::needless_borrow)]
on by default
framework/meta/src/template/template_adjuster.rs|141 col 41| warning: this expression creates a reference which is immediately dereferenced by the compiler
--> framework/meta/src/template/template_adjuster.rs:141:41
|
141 | &self.get_dependecy(&new_template_name),
| ^^^^^^^^^^^^^^^^^^ help: change this to: new_template_name
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
framework/meta/src/template/template_adjuster.rs|147 col 54| warning: writing &String
instead of &str
involves a new object where a slice will do
--> framework/meta/src/template/template_adjuster.rs:147:54
|
147 | fn rename_in_scenarios(&self, new_template_name: &String) {
| ^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
help: change this to
|
147 ~ fn rename_in_scenarios(&self, new_template_name: &str) {
148 | let mut old_wasm = self.metadata.name.clone();
149 | old_wasm.push_str(".wasm");
150 ~ let mut new_wasm = new_template_name.to_owned();
|
framework/meta/src/template/template_adjuster.rs|165 col 27| warning: this expression creates a reference which is immediately dereferenced by the compiler
--> framework/meta/src/template/template_adjuster.rs:165:27
|
165 | new_path.push_str(&new_template_name);
| ^^^^^^^^^^^^^^^^^^ help: change this to: new_template_name
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
framework/meta/src/template/template_adjuster.rs|166 col 9| warning: calling push_str()
using a single-character string literal
--> framework/meta/src/template/template_adjuster.rs:166:9
|
166 | new_path.push_str(""");
| ^^^^^^^^^^^^^^^^^^^^^^^ help: consider using push
with a character literal: new_path.push('\"')
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str
= note: #[warn(clippy::single_char_add_str)]
on by default
framework/meta/src/template/template_adjuster.rs|169 col 9| warning: calling push_str()
using a single-character string literal
--> framework/meta/src/template/template_adjuster.rs:169:9
|
169 | old_path.push_str(""");
| ^^^^^^^^^^^^^^^^^^^^^^^ help: consider using push
with a character literal: old_path.push('\"')
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str
framework/meta/src/template/template_adjuster.rs|206 col 42| warning: writing &String
instead of &str
involves a new object where a slice will do
--> framework/meta/src/template/template_adjuster.rs:206:42
|
206 | fn get_package_name(&self, template: &String) -> String {
| ^^^^^^^ help: change this to: &str
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
framework/meta/src/template/template_adjuster.rs|209 col 9| warning: calling push_str()
using a single-character string literal
--> framework/meta/src/template/template_adjuster.rs:209:9
|
209 | package.push_str(""");
| ^^^^^^^^^^^^^^^^^^^^^^ help: consider using push
with a character literal: package.push('\"')
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str
framework/meta/src/template/template_adjuster.rs|214 col 29| warning: this expression creates a reference which is immediately dereferenced by the compiler
--> framework/meta/src/template/template_adjuster.rs:214:29
|
214 | dependency.push_str(&template);
| ^^^^^^^^^ help: change this to: template
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
framework/meta/src/template/template_adjuster.rs|79 col 50| warning: writing &String
instead of &str
involves a new object where a slice will do
--> framework/meta/src/template/template_adjuster.rs:79:50
|
79 | fn rename_trait_to(&self, new_template_name: &String) {
| ^^^^^^^ help: change this to: &str
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
= note: #[warn(clippy::ptr_arg)]
on by default
framework/meta/src/template/template_adjuster.rs|121 col 41| warning: this expression creates a reference which is immediately dereferenced by the compiler
--> framework/meta/src/template/template_adjuster.rs:121:41
|
121 | &self.get_dependecy(&new_template_name),
| ^^^^^^^^^^^^^^^^^^ help: change this to: new_template_name
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
= note: #[warn(clippy::needless_borrow)]
on by default
framework/meta/src/template/template_adjuster.rs|141 col 41| warning: this expression creates a reference which is immediately dereferenced by the compiler
--> framework/meta/src/template/template_adjuster.rs:141:41
|
141 | &self.get_dependecy(&new_template_name),
| ^^^^^^^^^^^^^^^^^^ help: change this to: new_template_name
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
framework/meta/src/template/template_adjuster.rs|147 col 54| warning: writing &String
instead of &str
involves a new object where a slice will do
--> framework/meta/src/template/template_adjuster.rs:147:54
|
147 | fn rename_in_scenarios(&self, new_template_name: &String) {
| ^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
help: change this to
|
147 ~ fn rename_in_scenarios(&self, new_template_name: &str) {
148 | let mut old_wasm = self.metadata.name.clone();
149 | old_wasm.push_str(".wasm");
150 ~ let mut new_wasm = new_template_name.to_owned();
|
framework/meta/src/template/template_adjuster.rs|165 col 27| warning: this expression creates a reference which is immediately dereferenced by the compiler
--> framework/meta/src/template/template_adjuster.rs:165:27
|
165 | new_path.push_str(&new_template_name);
| ^^^^^^^^^^^^^^^^^^ help: change this to: new_template_name
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
framework/meta/src/template/template_adjuster.rs|166 col 9| warning: calling push_str()
using a single-character string literal
--> framework/meta/src/template/template_adjuster.rs:166:9
|
166 | new_path.push_str(""");
| ^^^^^^^^^^^^^^^^^^^^^^^ help: consider using push
with a character literal: new_path.push('\"')
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str
= note: #[warn(clippy::single_char_add_str)]
on by default
framework/meta/src/template/template_adjuster.rs|169 col 9| warning: calling push_str()
using a single-character string literal
--> framework/meta/src/template/template_adjuster.rs:169:9
|
169 | old_path.push_str(""");
| ^^^^^^^^^^^^^^^^^^^^^^^ help: consider using push
with a character literal: old_path.push('\"')
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str
framework/meta/src/template/template_adjuster.rs|206 col 42| warning: writing &String
instead of &str
involves a new object where a slice will do
--> framework/meta/src/template/template_adjuster.rs:206:42
|
206 | fn get_package_name(&self, template: &String) -> String {
| ^^^^^^^ help: change this to: &str
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
framework/meta/src/template/template_adjuster.rs|209 col 9| warning: calling push_str()
using a single-character string literal
--> framework/meta/src/template/template_adjuster.rs:209:9
|
209 | package.push_str(""");
| ^^^^^^^^^^^^^^^^^^^^^^ help: consider using push
with a character literal: package.push('\"')
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str
framework/meta/src/template/template_adjuster.rs|214 col 29| warning: this expression creates a reference which is immediately dereferenced by the compiler
--> framework/meta/src/template/template_adjuster.rs:214:29
|
214 | dependency.push_str(&template);
| ^^^^^^^^^ help: change this to: template
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
Filtered Findings (18)
sdk/scenario-format/src/serde_raw/esdt_data_raw/esdt_instances_raw_check.rs|25 col 1| warning: this impl
can be derived
--> sdk/scenario-format/src/serde_raw/esdt_data_raw/esdt_instances_raw_check.rs:25:1
|
25 | / impl Default for CheckEsdtInstancesRaw {
26 | | fn default() -> Self {
27 | | CheckEsdtInstancesRaw::Unspecified
28 | | }
29 | | }
| |^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls
= note: #[warn(clippy::derivable_impls)]
on by default
= help: remove the manual implementation...
help: ...and instead derive it...
|
9 + #[derive(Default)]
10 | pub enum CheckEsdtInstancesRaw {
|
help: ...and mark the default variant
|
10 ~ #[default]
11 ~ Unspecified,
|
sdk/scenario-format/src/serde_raw/esdt_data_raw/esdt_map_raw_check.rs|24 col 1| warning: this impl
can be derived
--> sdk/scenario-format/src/serde_raw/esdt_data_raw/esdt_map_raw_check.rs:24:1
|
24 | / impl Default for CheckEsdtMapRaw {
25 | | fn default() -> Self {
26 | | CheckEsdtMapRaw::Unspecified
27 | | }
28 | | }
| |^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls
= help: remove the manual implementation...
help: ...and instead derive it...
|
8 + #[derive(Default)]
9 | pub enum CheckEsdtMapRaw {
|
help: ...and mark the default variant
|
9 ~ #[default]
10 ~ Unspecified,
|
sdk/scenario-format/src/serde_raw/logs_raw.rs|32 col 1| warning: this impl
can be derived
--> sdk/scenario-format/src/serde_raw/logs_raw.rs:32:1
|
32 | / impl Default for CheckLogsRaw {
33 | | fn default() -> Self {
34 | | CheckLogsRaw::Unspecified
35 | | }
36 | | }
| |^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls
= help: remove the manual implementation...
help: ...and instead derive it...
|
16 + #[derive(Default)]
17 | pub enum CheckLogsRaw {
|
help: ...and mark the default variant
|
19 ~ #[default]
20 ~ Unspecified,
|
sdk/scenario-format/src/serde_raw/value_raw_check.rs|24 col 1| warning: this impl
can be derived
--> sdk/scenario-format/src/serde_raw/value_raw_check.rs:24:1
|
24 | / impl Default for CheckBytesValueRaw {
25 | | fn default() -> Self {
26 | | CheckBytesValueRaw::Unspecified
27 | | }
28 | | }
| |^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls
= help: remove the manual implementation...
help: ...and instead derive it...
|
8 + #[derive(Default)]
9 | pub enum CheckBytesValueRaw {
|
help: ...and mark the default variant
|
9 ~ #[default]
10 ~ Unspecified,
|
sdk/scenario-format/src/serde_raw/value_raw_check_list.rs|24 col 1| warning: this impl
can be derived
--> sdk/scenario-format/src/serde_raw/value_raw_check_list.rs:24:1
|
24 | / impl Default for CheckValueListRaw {
25 | | fn default() -> Self {
26 | | CheckValueListRaw::Unspecified
27 | | }
28 | | }
| |^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls
= help: remove the manual implementation...
help: ...and instead derive it...
|
8 + #[derive(Default)]
9 | pub enum CheckValueListRaw {
|
help: ...and mark the default variant
|
9 ~ #[default]
10 ~ Unspecified,
|
vm/src/scenario/model/esdt_data/esdt_map_check.rs|15 col 1| warning: this impl
can be derived
--> vm/src/scenario/model/esdt_data/esdt_map_check.rs:15:1
|
15 | / impl Default for CheckEsdtMap {
16 | | fn default() -> Self {
17 | | CheckEsdtMap::Unspecified
18 | | }
19 | | }
| |^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls
= note: #[warn(clippy::derivable_impls)]
on by default
= help: remove the manual implementation...
help: ...and instead derive it...
|
9 + #[derive(Default)]
10 | pub enum CheckEsdtMap {
|
help: ...and mark the default variant
|
10 ~ #[default]
11 ~ Unspecified,
|
vm/src/scenario/model/storage_check.rs|14 col 1| warning: this impl
can be derived
--> vm/src/scenario/model/storage_check.rs:14:1
|
14 | / impl Default for CheckStorage {
15 | | fn default() -> Self {
16 | | CheckStorage::Star
17 | | }
18 | | }
| |^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls
= help: remove the manual implementation...
help: ...and instead derive it...
|
9 + #[derive(Default)]
10 | pub enum CheckStorage {
|
help: ...and mark the default variant
|
10 ~ #[default]
11 ~ Star,
|
vm/src/scenario/model/value/value_check.rs|25 col 1| warning: this impl
can be derived
--> vm/src/scenario/model/value/value_check.rs:25:1
|
25 | / impl Default for CheckValue
26 | | where
27 | | T: Default,
28 | | {
... |
31 | | }
32 | | }
| |^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls
= help: remove the manual implementation...
help: ...and instead derive it...
|
11 + #[derive(Default)]
12 | pub enum CheckValue<T: Default> {
|
help: ...and mark the default variant
|
12 ~ #[default]
13 ~ Star,
|
contracts/examples/bonding-curve-contract/src/function_selector.rs|16 col 1| warning: this impl
can be derived
--> contracts/examples/bonding-curve-contract/src/function_selector.rs:16:1
|
16 | / impl<M: ManagedTypeApi> Default for FunctionSelector {
17 | | fn default() -> Self {
18 | | FunctionSelector::None
19 | | }
20 | | }
| |^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls
= note: #[warn(clippy::derivable_impls)]
on by default
= help: remove the manual implementation...
help: ...and instead derive it...
|
10 + #[derive(Default)]
11 | pub enum FunctionSelector<M: ManagedTypeApi> {
|
help: ...and mark the default variant
|
13 ~ #[default]
14 ~ None,
|
contracts/examples/bonding-curve-contract/src/function_selector.rs|16 col 1| warning: this impl
can be derived
--> contracts/examples/bonding-curve-contract/src/function_selector.rs:16:1
|
16 | / impl<M: ManagedTypeApi> Default for FunctionSelector {
17 | | fn default() -> Self {
18 | | FunctionSelector::None
19 | | }
20 | | }
| |^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls
= note: #[warn(clippy::derivable_impls)]
on by default
= help: remove the manual implementation...
help: ...and instead derive it...
|
10 + #[derive(Default)]
11 | pub enum FunctionSelector<M: ManagedTypeApi> {
|
help: ...and mark the default variant
|
13 ~ #[default]
14 ~ None,
|
vm/src/scenario/model/esdt_data/esdt_map_check.rs|15 col 1| warning: this impl
can be derived
--> vm/src/scenario/model/esdt_data/esdt_map_check.rs:15:1
|
15 | / impl Default for CheckEsdtMap {
16 | | fn default() -> Self {
17 | | CheckEsdtMap::Unspecified
18 | | }
19 | | }
| |^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls
= note: #[warn(clippy::derivable_impls)]
on by default
= help: remove the manual implementation...
help: ...and instead derive it...
|
9 + #[derive(Default)]
10 | pub enum CheckEsdtMap {
|
help: ...and mark the default variant
|
10 ~ #[default]
11 ~ Unspecified,
|
vm/src/scenario/model/storage_check.rs|14 col 1| warning: this impl
can be derived
--> vm/src/scenario/model/storage_check.rs:14:1
|
14 | / impl Default for CheckStorage {
15 | | fn default() -> Self {
16 | | CheckStorage::Star
17 | | }
18 | | }
| |^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls
= help: remove the manual implementation...
help: ...and instead derive it...
|
9 + #[derive(Default)]
10 | pub enum CheckStorage {
|
help: ...and mark the default variant
|
10 ~ #[default]
11 ~ Star,
|
vm/src/scenario/model/value/value_check.rs|25 col 1| warning: this impl
can be derived
--> vm/src/scenario/model/value/value_check.rs:25:1
|
25 | / impl Default for CheckValue
26 | | where
27 | | T: Default,
28 | | {
... |
31 | | }
32 | | }
| |^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls
= help: remove the manual implementation...
help: ...and instead derive it...
|
11 + #[derive(Default)]
12 | pub enum CheckValue<T: Default> {
|
help: ...and mark the default variant
|
12 ~ #[default]
13 ~ Star,
|
sdk/scenario-format/src/serde_raw/esdt_data_raw/esdt_instances_raw_check.rs|25 col 1| warning: this impl
can be derived
--> sdk/scenario-format/src/serde_raw/esdt_data_raw/esdt_instances_raw_check.rs:25:1
|
25 | / impl Default for CheckEsdtInstancesRaw {
26 | | fn default() -> Self {
27 | | CheckEsdtInstancesRaw::Unspecified
28 | | }
29 | | }
| |^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls
= note: #[warn(clippy::derivable_impls)]
on by default
= help: remove the manual implementation...
help: ...and instead derive it...
|
9 + #[derive(Default)]
10 | pub enum CheckEsdtInstancesRaw {
|
help: ...and mark the default variant
|
10 ~ #[default]
11 ~ Unspecified,
|
sdk/scenario-format/src/serde_raw/esdt_data_raw/esdt_map_raw_check.rs|24 col 1| warning: this impl
can be derived
--> sdk/scenario-format/src/serde_raw/esdt_data_raw/esdt_map_raw_check.rs:24:1
|
24 | / impl Default for CheckEsdtMapRaw {
25 | | fn default() -> Self {
26 | | CheckEsdtMapRaw::Unspecified
27 | | }
28 | | }
| |^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls
= help: remove the manual implementation...
help: ...and instead derive it...
|
8 + #[derive(Default)]
9 | pub enum CheckEsdtMapRaw {
|
help: ...and mark the default variant
|
9 ~ #[default]
10 ~ Unspecified,
|
sdk/scenario-format/src/serde_raw/logs_raw.rs|32 col 1| warning: this impl
can be derived
--> sdk/scenario-format/src/serde_raw/logs_raw.rs:32:1
|
32 | / impl Default for CheckLogsRaw {
33 | | fn default() -> Self {
34 | | CheckLogsRaw::Unspecified
35 | | }
36 | | }
| |^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls
= help: remove the manual implementation...
help: ...and instead derive it...
|
16 + #[derive(Default)]
17 | pub enum CheckLogsRaw {
|
help: ...and mark the default variant
|
19 ~ #[default]
20 ~ Unspecified,
|
sdk/scenario-format/src/serde_raw/value_raw_check.rs|24 col 1| warning: this impl
can be derived
--> sdk/scenario-format/src/serde_raw/value_raw_check.rs:24:1
|
24 | / impl Default for CheckBytesValueRaw {
25 | | fn default() -> Self {
26 | | CheckBytesValueRaw::Unspecified
27 | | }
28 | | }
| |^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls
= help: remove the manual implementation...
help: ...and instead derive it...
|
8 + #[derive(Default)]
9 | pub enum CheckBytesValueRaw {
|
help: ...and mark the default variant
|
9 ~ #[default]
10 ~ Unspecified,
|
sdk/scenario-format/src/serde_raw/value_raw_check_list.rs|24 col 1| warning: this impl
can be derived
--> sdk/scenario-format/src/serde_raw/value_raw_check_list.rs:24:1
|
24 | / impl Default for CheckValueListRaw {
25 | | fn default() -> Self {
26 | | CheckValueListRaw::Unspecified
27 | | }
28 | | }
| |^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls
= help: remove the manual implementation...
help: ...and instead derive it...
|
8 + #[derive(Default)]
9 | pub enum CheckValueListRaw {
|
help: ...and mark the default variant
|
9 ~ #[default]
10 ~ Unspecified,
|
Annotations
Check warning on line 79 in framework/meta/src/template/template_adjuster.rs
github-actions / clippy
[clippy] framework/meta/src/template/template_adjuster.rs#L79
warning: writing `&String` instead of `&str` involves a new object where a slice will do
--> framework/meta/src/template/template_adjuster.rs:79:50
|
79 | fn rename_trait_to(&self, new_template_name: &String) {
| ^^^^^^^ help: change this to: `&str`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
= note: `#[warn(clippy::ptr_arg)]` on by default
Raw output
framework/meta/src/template/template_adjuster.rs:79:50:w:warning: writing `&String` instead of `&str` involves a new object where a slice will do
--> framework/meta/src/template/template_adjuster.rs:79:50
|
79 | fn rename_trait_to(&self, new_template_name: &String) {
| ^^^^^^^ help: change this to: `&str`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
= note: `#[warn(clippy::ptr_arg)]` on by default
__END__
Check warning on line 121 in framework/meta/src/template/template_adjuster.rs
github-actions / clippy
[clippy] framework/meta/src/template/template_adjuster.rs#L121
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> framework/meta/src/template/template_adjuster.rs:121:41
|
121 | &self.get_dependecy(&new_template_name),
| ^^^^^^^^^^^^^^^^^^ help: change this to: `new_template_name`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
= note: `#[warn(clippy::needless_borrow)]` on by default
Raw output
framework/meta/src/template/template_adjuster.rs:121:41:w:warning: this expression creates a reference which is immediately dereferenced by the compiler
--> framework/meta/src/template/template_adjuster.rs:121:41
|
121 | &self.get_dependecy(&new_template_name),
| ^^^^^^^^^^^^^^^^^^ help: change this to: `new_template_name`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
= note: `#[warn(clippy::needless_borrow)]` on by default
__END__
Check warning on line 141 in framework/meta/src/template/template_adjuster.rs
github-actions / clippy
[clippy] framework/meta/src/template/template_adjuster.rs#L141
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> framework/meta/src/template/template_adjuster.rs:141:41
|
141 | &self.get_dependecy(&new_template_name),
| ^^^^^^^^^^^^^^^^^^ help: change this to: `new_template_name`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
Raw output
framework/meta/src/template/template_adjuster.rs:141:41:w:warning: this expression creates a reference which is immediately dereferenced by the compiler
--> framework/meta/src/template/template_adjuster.rs:141:41
|
141 | &self.get_dependecy(&new_template_name),
| ^^^^^^^^^^^^^^^^^^ help: change this to: `new_template_name`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
__END__
Check warning on line 147 in framework/meta/src/template/template_adjuster.rs
github-actions / clippy
[clippy] framework/meta/src/template/template_adjuster.rs#L147
warning: writing `&String` instead of `&str` involves a new object where a slice will do
--> framework/meta/src/template/template_adjuster.rs:147:54
|
147 | fn rename_in_scenarios(&self, new_template_name: &String) {
| ^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
help: change this to
|
147 ~ fn rename_in_scenarios(&self, new_template_name: &str) {
148 | let mut old_wasm = self.metadata.name.clone();
149 | old_wasm.push_str(".wasm");
150 ~ let mut new_wasm = new_template_name.to_owned();
|
Raw output
framework/meta/src/template/template_adjuster.rs:147:54:w:warning: writing `&String` instead of `&str` involves a new object where a slice will do
--> framework/meta/src/template/template_adjuster.rs:147:54
|
147 | fn rename_in_scenarios(&self, new_template_name: &String) {
| ^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
help: change this to
|
147 ~ fn rename_in_scenarios(&self, new_template_name: &str) {
148 | let mut old_wasm = self.metadata.name.clone();
149 | old_wasm.push_str(".wasm");
150 ~ let mut new_wasm = new_template_name.to_owned();
|
__END__
Check warning on line 165 in framework/meta/src/template/template_adjuster.rs
github-actions / clippy
[clippy] framework/meta/src/template/template_adjuster.rs#L165
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> framework/meta/src/template/template_adjuster.rs:165:27
|
165 | new_path.push_str(&new_template_name);
| ^^^^^^^^^^^^^^^^^^ help: change this to: `new_template_name`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
Raw output
framework/meta/src/template/template_adjuster.rs:165:27:w:warning: this expression creates a reference which is immediately dereferenced by the compiler
--> framework/meta/src/template/template_adjuster.rs:165:27
|
165 | new_path.push_str(&new_template_name);
| ^^^^^^^^^^^^^^^^^^ help: change this to: `new_template_name`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
__END__
Check warning on line 166 in framework/meta/src/template/template_adjuster.rs
github-actions / clippy
[clippy] framework/meta/src/template/template_adjuster.rs#L166
warning: calling `push_str()` using a single-character string literal
--> framework/meta/src/template/template_adjuster.rs:166:9
|
166 | new_path.push_str("\"");
| ^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `new_path.push('\"')`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str
= note: `#[warn(clippy::single_char_add_str)]` on by default
Raw output
framework/meta/src/template/template_adjuster.rs:166:9:w:warning: calling `push_str()` using a single-character string literal
--> framework/meta/src/template/template_adjuster.rs:166:9
|
166 | new_path.push_str("\"");
| ^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `new_path.push('\"')`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str
= note: `#[warn(clippy::single_char_add_str)]` on by default
__END__
Check warning on line 169 in framework/meta/src/template/template_adjuster.rs
github-actions / clippy
[clippy] framework/meta/src/template/template_adjuster.rs#L169
warning: calling `push_str()` using a single-character string literal
--> framework/meta/src/template/template_adjuster.rs:169:9
|
169 | old_path.push_str("\"");
| ^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `old_path.push('\"')`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str
Raw output
framework/meta/src/template/template_adjuster.rs:169:9:w:warning: calling `push_str()` using a single-character string literal
--> framework/meta/src/template/template_adjuster.rs:169:9
|
169 | old_path.push_str("\"");
| ^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `old_path.push('\"')`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str
__END__
Check warning on line 206 in framework/meta/src/template/template_adjuster.rs
github-actions / clippy
[clippy] framework/meta/src/template/template_adjuster.rs#L206
warning: writing `&String` instead of `&str` involves a new object where a slice will do
--> framework/meta/src/template/template_adjuster.rs:206:42
|
206 | fn get_package_name(&self, template: &String) -> String {
| ^^^^^^^ help: change this to: `&str`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
Raw output
framework/meta/src/template/template_adjuster.rs:206:42:w:warning: writing `&String` instead of `&str` involves a new object where a slice will do
--> framework/meta/src/template/template_adjuster.rs:206:42
|
206 | fn get_package_name(&self, template: &String) -> String {
| ^^^^^^^ help: change this to: `&str`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
__END__
Check warning on line 209 in framework/meta/src/template/template_adjuster.rs
github-actions / clippy
[clippy] framework/meta/src/template/template_adjuster.rs#L209
warning: calling `push_str()` using a single-character string literal
--> framework/meta/src/template/template_adjuster.rs:209:9
|
209 | package.push_str("\"");
| ^^^^^^^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `package.push('\"')`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str
Raw output
framework/meta/src/template/template_adjuster.rs:209:9:w:warning: calling `push_str()` using a single-character string literal
--> framework/meta/src/template/template_adjuster.rs:209:9
|
209 | package.push_str("\"");
| ^^^^^^^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `package.push('\"')`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str
__END__
Check warning on line 214 in framework/meta/src/template/template_adjuster.rs
github-actions / clippy
[clippy] framework/meta/src/template/template_adjuster.rs#L214
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> framework/meta/src/template/template_adjuster.rs:214:29
|
214 | dependency.push_str(&template);
| ^^^^^^^^^ help: change this to: `template`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
Raw output
framework/meta/src/template/template_adjuster.rs:214:29:w:warning: this expression creates a reference which is immediately dereferenced by the compiler
--> framework/meta/src/template/template_adjuster.rs:214:29
|
214 | dependency.push_str(&template);
| ^^^^^^^^^ help: change this to: `template`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
__END__
Check warning on line 79 in framework/meta/src/template/template_adjuster.rs
github-actions / clippy
[clippy] framework/meta/src/template/template_adjuster.rs#L79
warning: writing `&String` instead of `&str` involves a new object where a slice will do
--> framework/meta/src/template/template_adjuster.rs:79:50
|
79 | fn rename_trait_to(&self, new_template_name: &String) {
| ^^^^^^^ help: change this to: `&str`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
= note: `#[warn(clippy::ptr_arg)]` on by default
Raw output
framework/meta/src/template/template_adjuster.rs:79:50:w:warning: writing `&String` instead of `&str` involves a new object where a slice will do
--> framework/meta/src/template/template_adjuster.rs:79:50
|
79 | fn rename_trait_to(&self, new_template_name: &String) {
| ^^^^^^^ help: change this to: `&str`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
= note: `#[warn(clippy::ptr_arg)]` on by default
__END__
Check warning on line 121 in framework/meta/src/template/template_adjuster.rs
github-actions / clippy
[clippy] framework/meta/src/template/template_adjuster.rs#L121
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> framework/meta/src/template/template_adjuster.rs:121:41
|
121 | &self.get_dependecy(&new_template_name),
| ^^^^^^^^^^^^^^^^^^ help: change this to: `new_template_name`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
= note: `#[warn(clippy::needless_borrow)]` on by default
Raw output
framework/meta/src/template/template_adjuster.rs:121:41:w:warning: this expression creates a reference which is immediately dereferenced by the compiler
--> framework/meta/src/template/template_adjuster.rs:121:41
|
121 | &self.get_dependecy(&new_template_name),
| ^^^^^^^^^^^^^^^^^^ help: change this to: `new_template_name`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
= note: `#[warn(clippy::needless_borrow)]` on by default
__END__
Check warning on line 141 in framework/meta/src/template/template_adjuster.rs
github-actions / clippy
[clippy] framework/meta/src/template/template_adjuster.rs#L141
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> framework/meta/src/template/template_adjuster.rs:141:41
|
141 | &self.get_dependecy(&new_template_name),
| ^^^^^^^^^^^^^^^^^^ help: change this to: `new_template_name`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
Raw output
framework/meta/src/template/template_adjuster.rs:141:41:w:warning: this expression creates a reference which is immediately dereferenced by the compiler
--> framework/meta/src/template/template_adjuster.rs:141:41
|
141 | &self.get_dependecy(&new_template_name),
| ^^^^^^^^^^^^^^^^^^ help: change this to: `new_template_name`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
__END__
Check warning on line 147 in framework/meta/src/template/template_adjuster.rs
github-actions / clippy
[clippy] framework/meta/src/template/template_adjuster.rs#L147
warning: writing `&String` instead of `&str` involves a new object where a slice will do
--> framework/meta/src/template/template_adjuster.rs:147:54
|
147 | fn rename_in_scenarios(&self, new_template_name: &String) {
| ^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
help: change this to
|
147 ~ fn rename_in_scenarios(&self, new_template_name: &str) {
148 | let mut old_wasm = self.metadata.name.clone();
149 | old_wasm.push_str(".wasm");
150 ~ let mut new_wasm = new_template_name.to_owned();
|
Raw output
framework/meta/src/template/template_adjuster.rs:147:54:w:warning: writing `&String` instead of `&str` involves a new object where a slice will do
--> framework/meta/src/template/template_adjuster.rs:147:54
|
147 | fn rename_in_scenarios(&self, new_template_name: &String) {
| ^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
help: change this to
|
147 ~ fn rename_in_scenarios(&self, new_template_name: &str) {
148 | let mut old_wasm = self.metadata.name.clone();
149 | old_wasm.push_str(".wasm");
150 ~ let mut new_wasm = new_template_name.to_owned();
|
__END__
Check warning on line 165 in framework/meta/src/template/template_adjuster.rs
github-actions / clippy
[clippy] framework/meta/src/template/template_adjuster.rs#L165
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> framework/meta/src/template/template_adjuster.rs:165:27
|
165 | new_path.push_str(&new_template_name);
| ^^^^^^^^^^^^^^^^^^ help: change this to: `new_template_name`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
Raw output
framework/meta/src/template/template_adjuster.rs:165:27:w:warning: this expression creates a reference which is immediately dereferenced by the compiler
--> framework/meta/src/template/template_adjuster.rs:165:27
|
165 | new_path.push_str(&new_template_name);
| ^^^^^^^^^^^^^^^^^^ help: change this to: `new_template_name`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
__END__
Check warning on line 166 in framework/meta/src/template/template_adjuster.rs
github-actions / clippy
[clippy] framework/meta/src/template/template_adjuster.rs#L166
warning: calling `push_str()` using a single-character string literal
--> framework/meta/src/template/template_adjuster.rs:166:9
|
166 | new_path.push_str("\"");
| ^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `new_path.push('\"')`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str
= note: `#[warn(clippy::single_char_add_str)]` on by default
Raw output
framework/meta/src/template/template_adjuster.rs:166:9:w:warning: calling `push_str()` using a single-character string literal
--> framework/meta/src/template/template_adjuster.rs:166:9
|
166 | new_path.push_str("\"");
| ^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `new_path.push('\"')`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str
= note: `#[warn(clippy::single_char_add_str)]` on by default
__END__
Check warning on line 169 in framework/meta/src/template/template_adjuster.rs
github-actions / clippy
[clippy] framework/meta/src/template/template_adjuster.rs#L169
warning: calling `push_str()` using a single-character string literal
--> framework/meta/src/template/template_adjuster.rs:169:9
|
169 | old_path.push_str("\"");
| ^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `old_path.push('\"')`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str
Raw output
framework/meta/src/template/template_adjuster.rs:169:9:w:warning: calling `push_str()` using a single-character string literal
--> framework/meta/src/template/template_adjuster.rs:169:9
|
169 | old_path.push_str("\"");
| ^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `old_path.push('\"')`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str
__END__
Check warning on line 206 in framework/meta/src/template/template_adjuster.rs
github-actions / clippy
[clippy] framework/meta/src/template/template_adjuster.rs#L206
warning: writing `&String` instead of `&str` involves a new object where a slice will do
--> framework/meta/src/template/template_adjuster.rs:206:42
|
206 | fn get_package_name(&self, template: &String) -> String {
| ^^^^^^^ help: change this to: `&str`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
Raw output
framework/meta/src/template/template_adjuster.rs:206:42:w:warning: writing `&String` instead of `&str` involves a new object where a slice will do
--> framework/meta/src/template/template_adjuster.rs:206:42
|
206 | fn get_package_name(&self, template: &String) -> String {
| ^^^^^^^ help: change this to: `&str`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
__END__
Check warning on line 209 in framework/meta/src/template/template_adjuster.rs
github-actions / clippy
[clippy] framework/meta/src/template/template_adjuster.rs#L209
warning: calling `push_str()` using a single-character string literal
--> framework/meta/src/template/template_adjuster.rs:209:9
|
209 | package.push_str("\"");
| ^^^^^^^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `package.push('\"')`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str
Raw output
framework/meta/src/template/template_adjuster.rs:209:9:w:warning: calling `push_str()` using a single-character string literal
--> framework/meta/src/template/template_adjuster.rs:209:9
|
209 | package.push_str("\"");
| ^^^^^^^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `package.push('\"')`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str
__END__
Check warning on line 214 in framework/meta/src/template/template_adjuster.rs
github-actions / clippy
[clippy] framework/meta/src/template/template_adjuster.rs#L214
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> framework/meta/src/template/template_adjuster.rs:214:29
|
214 | dependency.push_str(&template);
| ^^^^^^^^^ help: change this to: `template`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
Raw output
framework/meta/src/template/template_adjuster.rs:214:29:w:warning: this expression creates a reference which is immediately dereferenced by the compiler
--> framework/meta/src/template/template_adjuster.rs:214:29
|
214 | dependency.push_str(&template);
| ^^^^^^^^^ help: change this to: `template`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
__END__