Skip to content

template renames

template renames #7

Triggered via pull request August 10, 2023 11:02
@alyn509alyn509
synchronize #1184
trait-rename
Status Failure
Total duration 6m 2s
Artifacts

template-test.yml

on: pull_request
Template tool test
5m 51s
Template tool test
Fit to window
Zoom out
Zoom in

Annotations

1 error and 25 warnings
Template tool test
Process completed with exit code 101.
[clippy] framework/meta/src/template/template_adjuster.rs#L79: framework/meta/src/template/template_adjuster.rs#L79
warning: writing `&String` instead of `&str` involves a new object where a slice will do --> framework/meta/src/template/template_adjuster.rs:79:50 | 79 | fn rename_trait_to(&self, new_template_name: &String) { | ^^^^^^^ help: change this to: `&str` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg = note: `#[warn(clippy::ptr_arg)]` on by default
[clippy] framework/meta/src/template/template_adjuster.rs#L121: framework/meta/src/template/template_adjuster.rs#L121
warning: this expression creates a reference which is immediately dereferenced by the compiler --> framework/meta/src/template/template_adjuster.rs:121:41 | 121 | &self.get_dependecy(&new_template_name), | ^^^^^^^^^^^^^^^^^^ help: change this to: `new_template_name` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow = note: `#[warn(clippy::needless_borrow)]` on by default
[clippy] framework/meta/src/template/template_adjuster.rs#L141: framework/meta/src/template/template_adjuster.rs#L141
warning: this expression creates a reference which is immediately dereferenced by the compiler --> framework/meta/src/template/template_adjuster.rs:141:41 | 141 | &self.get_dependecy(&new_template_name), | ^^^^^^^^^^^^^^^^^^ help: change this to: `new_template_name` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
[clippy] framework/meta/src/template/template_adjuster.rs#L147: framework/meta/src/template/template_adjuster.rs#L147
warning: writing `&String` instead of `&str` involves a new object where a slice will do --> framework/meta/src/template/template_adjuster.rs:147:54 | 147 | fn rename_in_scenarios(&self, new_template_name: &String) { | ^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg help: change this to | 147 ~ fn rename_in_scenarios(&self, new_template_name: &str) { 148 | let mut old_wasm = self.metadata.name.clone(); 149 | old_wasm.push_str(".wasm"); 150 ~ let mut new_wasm = new_template_name.to_owned(); |
[clippy] framework/meta/src/template/template_adjuster.rs#L165: framework/meta/src/template/template_adjuster.rs#L165
warning: this expression creates a reference which is immediately dereferenced by the compiler --> framework/meta/src/template/template_adjuster.rs:165:27 | 165 | new_path.push_str(&new_template_name); | ^^^^^^^^^^^^^^^^^^ help: change this to: `new_template_name` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
[clippy] framework/meta/src/template/template_adjuster.rs#L166: framework/meta/src/template/template_adjuster.rs#L166
warning: calling `push_str()` using a single-character string literal --> framework/meta/src/template/template_adjuster.rs:166:9 | 166 | new_path.push_str("\""); | ^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `new_path.push('\"')` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str = note: `#[warn(clippy::single_char_add_str)]` on by default
[clippy] framework/meta/src/template/template_adjuster.rs#L169: framework/meta/src/template/template_adjuster.rs#L169
warning: calling `push_str()` using a single-character string literal --> framework/meta/src/template/template_adjuster.rs:169:9 | 169 | old_path.push_str("\""); | ^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `old_path.push('\"')` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str
[clippy] framework/meta/src/template/template_adjuster.rs#L206: framework/meta/src/template/template_adjuster.rs#L206
warning: writing `&String` instead of `&str` involves a new object where a slice will do --> framework/meta/src/template/template_adjuster.rs:206:42 | 206 | fn get_package_name(&self, template: &String) -> String { | ^^^^^^^ help: change this to: `&str` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[clippy] framework/meta/src/template/template_adjuster.rs#L209: framework/meta/src/template/template_adjuster.rs#L209
warning: calling `push_str()` using a single-character string literal --> framework/meta/src/template/template_adjuster.rs:209:9 | 209 | package.push_str("\""); | ^^^^^^^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `package.push('\"')` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str
[clippy] framework/meta/src/template/template_adjuster.rs#L214: framework/meta/src/template/template_adjuster.rs#L214
warning: this expression creates a reference which is immediately dereferenced by the compiler --> framework/meta/src/template/template_adjuster.rs:214:29 | 214 | dependency.push_str(&template); | ^^^^^^^^^ help: change this to: `template` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
[clippy] framework/meta/src/template/template_adjuster.rs#L79: framework/meta/src/template/template_adjuster.rs#L79
warning: writing `&String` instead of `&str` involves a new object where a slice will do --> framework/meta/src/template/template_adjuster.rs:79:50 | 79 | fn rename_trait_to(&self, new_template_name: &String) { | ^^^^^^^ help: change this to: `&str` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg = note: `#[warn(clippy::ptr_arg)]` on by default
[clippy] framework/meta/src/template/template_adjuster.rs#L121: framework/meta/src/template/template_adjuster.rs#L121
warning: this expression creates a reference which is immediately dereferenced by the compiler --> framework/meta/src/template/template_adjuster.rs:121:41 | 121 | &self.get_dependecy(&new_template_name), | ^^^^^^^^^^^^^^^^^^ help: change this to: `new_template_name` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow = note: `#[warn(clippy::needless_borrow)]` on by default
[clippy] framework/meta/src/template/template_adjuster.rs#L141: framework/meta/src/template/template_adjuster.rs#L141
warning: this expression creates a reference which is immediately dereferenced by the compiler --> framework/meta/src/template/template_adjuster.rs:141:41 | 141 | &self.get_dependecy(&new_template_name), | ^^^^^^^^^^^^^^^^^^ help: change this to: `new_template_name` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
[clippy] framework/meta/src/template/template_adjuster.rs#L147: framework/meta/src/template/template_adjuster.rs#L147
warning: writing `&String` instead of `&str` involves a new object where a slice will do --> framework/meta/src/template/template_adjuster.rs:147:54 | 147 | fn rename_in_scenarios(&self, new_template_name: &String) { | ^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg help: change this to | 147 ~ fn rename_in_scenarios(&self, new_template_name: &str) { 148 | let mut old_wasm = self.metadata.name.clone(); 149 | old_wasm.push_str(".wasm"); 150 ~ let mut new_wasm = new_template_name.to_owned(); |
[clippy] framework/meta/src/template/template_adjuster.rs#L165: framework/meta/src/template/template_adjuster.rs#L165
warning: this expression creates a reference which is immediately dereferenced by the compiler --> framework/meta/src/template/template_adjuster.rs:165:27 | 165 | new_path.push_str(&new_template_name); | ^^^^^^^^^^^^^^^^^^ help: change this to: `new_template_name` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
[clippy] framework/meta/src/template/template_adjuster.rs#L166: framework/meta/src/template/template_adjuster.rs#L166
warning: calling `push_str()` using a single-character string literal --> framework/meta/src/template/template_adjuster.rs:166:9 | 166 | new_path.push_str("\""); | ^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `new_path.push('\"')` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str = note: `#[warn(clippy::single_char_add_str)]` on by default
[clippy] framework/meta/src/template/template_adjuster.rs#L169: framework/meta/src/template/template_adjuster.rs#L169
warning: calling `push_str()` using a single-character string literal --> framework/meta/src/template/template_adjuster.rs:169:9 | 169 | old_path.push_str("\""); | ^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `old_path.push('\"')` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str
[clippy] framework/meta/src/template/template_adjuster.rs#L206: framework/meta/src/template/template_adjuster.rs#L206
warning: writing `&String` instead of `&str` involves a new object where a slice will do --> framework/meta/src/template/template_adjuster.rs:206:42 | 206 | fn get_package_name(&self, template: &String) -> String { | ^^^^^^^ help: change this to: `&str` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[clippy] framework/meta/src/template/template_adjuster.rs#L209: framework/meta/src/template/template_adjuster.rs#L209
warning: calling `push_str()` using a single-character string literal --> framework/meta/src/template/template_adjuster.rs:209:9 | 209 | package.push_str("\""); | ^^^^^^^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `package.push('\"')` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str
[clippy] framework/meta/src/template/template_adjuster.rs#L214: framework/meta/src/template/template_adjuster.rs#L214
warning: this expression creates a reference which is immediately dereferenced by the compiler --> framework/meta/src/template/template_adjuster.rs:214:29 | 214 | dependency.push_str(&template); | ^^^^^^^^^ help: change this to: `template` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
Template tool test
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2, actions-rs/toolchain@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
Template tool test
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Template tool test
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Template tool test
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Template tool test
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/