Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve linemod2d clustering #20

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

RunqiuBao
Copy link

In linemod2D,

  1. use highest-score candidate first in linemod2D clustering, instead of merging everything inside cluster.
  2. add critical direction in linemod2D clustering.

@jerasman
Copy link

jerasman commented Apr 7, 2022

@RunqiuBao typo "perpendiculr". Also, where are your new variables documented? I didn't see their description

@RunqiuBao
Copy link
Author

Added docs and cleaned rotationalClustering.

@RunqiuBao
Copy link
Author

notes:
(1) definition of long object by 5 is ambiguous.
(2) critical direction <- use a better name.
(3) should support thin plane object as well.

@RunqiuBao
Copy link
Author

RunqiuBao commented Jul 11, 2022

@jerasman
Updated:
(0) longAndNarrowThreshold can be configured as a parameter when rendering template.
(1) change criticalDirection to narrowDirection
(2) support both long object and thin plane object.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants