Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs][base-ui] Add new batch of coming soon pages #38025

Merged
merged 27 commits into from
Aug 1, 2023

Conversation

danilo-leal
Copy link
Contributor

@danilo-leal danilo-leal commented Jul 18, 2023

Following @oliviertassinari's feedback in #37575 about missing pages for upcoming planned components. Additionally, tweaked the callout copy a tiny bit as well as changed the chip text from "Coming soon" to "Planned" given the discussion had in this PR. The new ones added are:

  1. Accordion
  2. Pagination
  3. Rating
  4. Tooltip
  5. Toggle Button Group
  6. Drawer

Preview: https://deploy-preview-38025--material-ui.netlify.app/base-ui/react-tooltip/

@danilo-leal danilo-leal added docs Improvements or additions to the documentation package: base-ui Specific to @mui/base labels Jul 18, 2023
@danilo-leal danilo-leal self-assigned this Jul 18, 2023
Copy link
Member

@oliviertassinari oliviertassinari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of ideas:

  1. In the title, I think adding 🚧 like in MUI X would help skip the page from the search:
Screenshot 2023-07-19 at 02 31 13
  1. There is a strange change of cursor on the badge:
Screen.Recording.2023-07-19.at.02.36.00.mov

This seems to be an old bug, I stopped my origin hunt at 943f95f#diff-d1439e644fd94d980426ac362fcc36489ba82e228bab753e9a37dd96c61fded4R29 but it's even older. As far as I know, this style is crap, to remove. Joy UI has is correct IMHO https://deploy-preview-38025--material-ui.netlify.app/joy-ui/react-chip/#basic-usage.

cc @DiegoAndai

  1. "do just want to point out that we may want to strike a max number of coming soon components in the docs given having 6 there already looks like a bit too many"

With MUI X, we literally added all the missing features in the docs, each with its own issues, we had about 20, it worked out really well. I think that the issue is with the design and wording. I would connect this back to #36279 (comment). Something like this would draw less attention.

Screenshot 2023-07-19 at 02 52 07

@danilo-leal
Copy link
Contributor Author

@oliviertassinari Interesting, appreciate the feedback! I'm a bit torn on using emojis ⎯ they look a bit cluttered to me but I also see that "Coming soon" as a label might be too long. Wondering if just using "Soon" would cut it?! I wish we could use actual icons though ⎯ would that be possible? Not necessarily on the chip but to help out with the search use case you mentioned, which definitely makes sense!

About the cursor change: is there anything we could do here to fix it?

@oliviertassinari
Copy link
Member

oliviertassinari commented Jul 19, 2023

but I also see that "Coming soon" as a label might be too long

@danilo-leal I had the feedback from a friend that "Coming soon" is confusing, he feels that has been waiting on one of the components forever (Joy UI's accordion). MUI X refers to them as "upcoming": https://mui.com/x/react-data-grid/#upcoming-features this is more relevant to me. So maybe simply "Planned" would be great?

I wish we could use actual icons though ⎯ would that be possible? Not necessarily on the chip but to help out with the search use case you mentioned, which definitely makes sense!

It's possible with the docs search, but it's a bit more involved, we need to store the data in the Algolia index. Since we are already using 🚧 for the page h1 with MUI X, I think that we could start there, and improve it as another step.

About the cursor change: is there anything we could do here to fix it?

  • I think it would be great for @DiegoAndai to own the fix. It's likely a one-line change to Material UI 😁

@danilo-leal
Copy link
Contributor Author

@oliviertassinari I'm cool with either of these (Planned or Upcoming), they're definitely better than "Coming soon" or "Soon"! 🤙 And about the emoji on the title, that's fair ⎯ too much work to flow with Algolia now 😬

@DiegoAndai
Copy link
Member

DiegoAndai commented Jul 20, 2023

Will look into the Chip cursor fix. Fixed in #38076

@oliviertassinari oliviertassinari changed the title [docs][base] Add new batch of coming soon pages [docs][base-ui] Add new batch of coming soon pages Jul 24, 2023
@danilo-leal
Copy link
Contributor Author

@michaldudak & @oliviertassinari hey y'all, circling back to this as it would be great to have it merged this week. Some pending actions/questions that I have visibility of to move forward ⎯ let me know if I'm missing something:

  1. Should we add a chip for all the other components this PR hasn't yet covered? (I'm checking the full list)
  2. Refine the copy to communicate to a user's benefit (i.e., "help prioritize" to "see it faster")
  3. Not really sure why the test_static test is failing ⎯ when running yarn:docs:api, some other test fails 🤔

@oliviertassinari oliviertassinari force-pushed the add-more-baseui-comingsoon-pages branch from 86ebf0b to d01bba9 Compare July 31, 2023 14:59
@michaldudak
Copy link
Member

Should we add a chip for all the other components this PR hasn't yet covered?

I feel like it could add too much noise. Plus, we don't really know if we'll work on all of these components. The issues are there to measure interest.

Refine the copy to communicate to a user's benefit (i.e., "help prioritize" to "see it faster")

I'd leave the exact content for people who are better with words than me, but I feel like it's important to underline why we need feedback (upvotes, but also features people would like to see in these components).

@oliviertassinari
Copy link
Member

oliviertassinari commented Jul 31, 2023

  1. Should we add a chip for all the other components this PR hasn't yet covered?

Agree with Michal, 👍 for only the one we know we will build. I think we do this PR to 1. learn in which order they should be built & 2. to increase the trust with the developers that these will be eventually implemented.

More ideas for components that could make sense to build:

  • Avatar: for the image loading logic.
  • Context Menu: Material UI would need this as well
  • Menu Bar
  • Navigation Menu
  1. Refine the copy to communicate to a user's benefit (i.e., "help prioritize" to "see it faster")

I think that the best drives are the ones anchored on our selfishness. I would be amazed if "see it faster" doesn't work better than "help us prioritize", at least based on how I would behave seeing each variant.

At the end of the day, we build components so that people can use them to solve their problems, "see it faster" has one less indirection toward what is eventually success () vs. "help us prioritize" which makes a hop with MUI.

Having said this, we could also remove the notion of MUI in the framing, while keeping the prioritization notion, as long as it's centered on win for the user, no issues on my end.

@oliviertassinari oliviertassinari force-pushed the add-more-baseui-comingsoon-pages branch from a5457fa to 1d7eb49 Compare July 31, 2023 20:44
@danilo-leal
Copy link
Contributor Author

danilo-leal commented Jul 31, 2023

as long as it's centered on win for the user

Sounds like a good motto for me! Resonates with what @samuelsycamore frequently makes us ask ourselves (i.e. "what is there for the reader?") 🤙

@danilo-leal danilo-leal merged commit b63a7aa into master Aug 1, 2023
11 checks passed
@danilo-leal danilo-leal deleted the add-more-baseui-comingsoon-pages branch August 1, 2023 02:38
richbustos pushed a commit that referenced this pull request Aug 4, 2023
richbustos pushed a commit that referenced this pull request Aug 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to the documentation package: base-ui Specific to @mui/base
Projects
Status: Done
Status: Recently completed
Development

Successfully merging this pull request may close these issues.

6 participants