-
-
Notifications
You must be signed in to change notification settings - Fork 32.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs][base] Add pages for coming soon components #37575
Conversation
Netlify deploy preview
Bundle size report |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have just one remark. Besides that (and the info message improvement), I think it's good to go!
Co-authored-by: Sam Sycamore <[email protected]> Signed-off-by: Danilo Leal <[email protected]>
@michaldudak & @brijeshb42 mind giving this one a second look, please? 🙌 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine to me now!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Great to see these pages! Regarding how we could improve them:
|
@oliviertassinari for the first part of your message, maybe a better place to drop this feedback would be on the all-encompassing unstyled components progress issue (mui/base-ui#10)? I agree with it, though! As for the other part, I can add pages for them, no problem! |
@danilo-leal mui/base-ui#10 is the umbrella issue, it's definitely connected 👍. @michaldudak What do you think about we create one GitHub issue for each unstyled components left to build? As far as I know each takes a lot of work, so we wouldn't have overkill small GitHub issues 😁. |
Yup, it makes sense. We can discuss the API design and implementation details in these issues. I'll create them. |
@michaldudak Awesome, this is inline with https://ark-ui.canny.io/feature-requests/p/date-picker-react or ariakit/ariakit#955. Once Danilo comes back from holiday, we can get #38025 live. |
This PR is adding pages for coming soon Base UI components ⎯ the ones starred in the umbrella issue: Checkbox, Radio, and Accordion. These are the ones that might come super close after the stable release.
Preview: https://deploy-preview-37575--material-ui.netlify.app/base-ui/react-checkbox/ related to mui/base-ui#10