Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs][base] Add pages for coming soon components #37575

Merged
merged 10 commits into from
Jun 19, 2023

Conversation

danilo-leal
Copy link
Contributor

@danilo-leal danilo-leal commented Jun 12, 2023

This PR is adding pages for coming soon Base UI components ⎯ the ones starred in the umbrella issue: Checkbox, Radio, and Accordion. These are the ones that might come super close after the stable release.

Preview: https://deploy-preview-37575--material-ui.netlify.app/base-ui/react-checkbox/ related to mui/base-ui#10

@danilo-leal danilo-leal added docs Improvements or additions to the documentation package: base-ui Specific to @mui/base labels Jun 12, 2023
@danilo-leal danilo-leal added this to the Base UI: Stable release milestone Jun 12, 2023
@danilo-leal danilo-leal self-assigned this Jun 12, 2023
@mui-bot
Copy link

mui-bot commented Jun 12, 2023

Copy link
Member

@michaldudak michaldudak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have just one remark. Besides that (and the info message improvement), I think it's good to go!

docs/data/base/components/radio-button/radio-button.md Outdated Show resolved Hide resolved
@danilo-leal
Copy link
Contributor Author

@michaldudak & @brijeshb42 mind giving this one a second look, please? 🙌

Copy link
Member

@michaldudak michaldudak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me now!

Copy link
Contributor

@brijeshb42 brijeshb42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@danilo-leal danilo-leal merged commit 56bf57d into master Jun 19, 2023
@danilo-leal danilo-leal deleted the base-coming-soon-components branch June 19, 2023 12:22
@oliviertassinari
Copy link
Member

oliviertassinari commented Jul 18, 2023

Great to see these pages!

Regarding how we could improve them:

  • I think that it would be much better if we had one GitHub issue for each unstyled component that is left to be built. This would allow:

    • To collect more refined upvotes and linked issues on each case, knowing which component to build first.
    • Allow the developers to subscribe to only the components that haven't been built yet, getting notified when we close them.
    • Collaborate with the community on the right API & solution for each.
    • We could also work with the developers from the community to build some of them as they did in the past. They have built most of the components in Material UI (in their first version). Typically, we could instruct them to extract Material UI logic and adopt Base UI patterns, the sooner we get them in an unstable state, the better. So: we can build Material UI v6 on it, so we can differentiate with other headless libraries.
  • I think that we miss more pages:

    • Tooltip
    • Pagination
    • Rating

@danilo-leal
Copy link
Contributor Author

danilo-leal commented Jul 18, 2023

@oliviertassinari for the first part of your message, maybe a better place to drop this feedback would be on the all-encompassing unstyled components progress issue (mui/base-ui#10)? I agree with it, though!

As for the other part, I can add pages for them, no problem!

@oliviertassinari
Copy link
Member

oliviertassinari commented Jul 18, 2023

for the first part of your message, maybe a better place to drop this feedback would be on the all-encompassing unstyled components progress issue (#27170)? I agree with it, though!

@danilo-leal mui/base-ui#10 is the umbrella issue, it's definitely connected 👍.

@michaldudak What do you think about we create one GitHub issue for each unstyled components left to build? As far as I know each takes a lot of work, so we wouldn't have overkill small GitHub issues 😁.

@michaldudak
Copy link
Member

What do you think about we create one GitHub issue for each unstyled components left to build?

Yup, it makes sense. We can discuss the API design and implementation details in these issues. I'll create them.

@michaldudak
Copy link
Member

Here's the whole list: https://github.com/mui/material-ui/issues?q=is%3Aopen+is%3Aissue+label%3A%22package%3A+base-ui%22+label%3A%22new+feature%22+hook+in%3Atitle

@oliviertassinari
Copy link
Member

@michaldudak Awesome, this is inline with https://ark-ui.canny.io/feature-requests/p/date-picker-react or ariakit/ariakit#955.

Once Danilo comes back from holiday, we can get #38025 live.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to the documentation package: base-ui Specific to @mui/base
Projects
Status: Recently completed
Development

Successfully merging this pull request may close these issues.

6 participants