Rename OSX to macOS to better reflect the newest naming for this platform #840
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julienw
changed the title
✅ Deploy Preview for mozilla-perfcompare ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #840 +/- ##
=======================================
Coverage 92.63% 92.63%
=======================================
Files 93 93
Lines 2579 2579
Branches 513 513
=======================================
Hits 2389 2389
Misses 168 168
Partials 22 22 ☔ View full report in Codecov by Sentry. |
Carla-Moz
approved these changes
Jan 14, 2025
Merged
julienw
added a commit
that referenced
this pull request
Jan 15, 2025
Updates: [Julien Wajsberg] Small adjustments on the sort functionality (#837) [esanuandra] PCF-562 Consider adding the OS version to the name of the platform in the "Platform" column (#816) [Carla Severe] Removed repetitive style references (#836) [Julien Wajsberg] Rename OSX to macOS to better reflect the newest naming for this platform (#840) [Julien Wajsberg] Extract the table filtering code to a common file (#839) [Julien Wajsberg] Implement sorting on the main results page (#838) [Chineta Adinnu] Add tooltips to revision column headers (#832) [Chineta Adinnu] Add aria expanded to revision row expand button (#826)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This mostly just changes the option in the menu, to be more consistent after @esanuandra 's changes in #816 :
This will also change the displayed platform from
OSXtomacOSwhen a platform isn't in the platform map.I was also considering changing these to
macOSas well for consistency:perfcompare/src/utils/platform.ts
Lines 23 to 26 in bee2cf6
What do you think?
deploy preview