Deploy January 15, 2025 #842
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Filter by the absolute value of delta instead of the signed value * Make the sort direction at the first click 'desc' instead of 'asc'
… the "Platform" column (#816) * Add os version * Refactor * Fix tests * Add os version on subtests * fix typescript error * Address code review, nit changes
* remove repetitive style references * update snapshots * deleted unused styles and classes
* Add sort functions to the columns configuration array * Sort the results in TableContent * Add a default sort function, specific to the main table * Remove unused test fixtures * Show the delta value in the tool summarizeVisibleRows * Add new tests * Extract the table sorting code to a common file
✅ Deploy Preview for mozilla-perfcompare ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates:
[Julien Wajsberg] Small adjustments on the sort functionality (#837)
[esanuandra] PCF-562 Consider adding the OS version to the name of the platform in the "Platform" column (#816)
[Carla Severe] Removed repetitive style references (#836)
[Julien Wajsberg] Rename OSX to macOS to better reflect the newest naming for this platform (#840)
[Julien Wajsberg] Extract the table filtering code to a common file (#839)
[Julien Wajsberg] Implement sorting on the main results page (#838)
[Chineta Adinnu] Add tooltips to revision column headers (#832)
[Chineta Adinnu] Add aria expanded to revision row expand button (#826)