Implement sorting on the main results page #838
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for mozilla-perfcompare ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #838 +/- ##
==========================================
+ Coverage 93.20% 93.38% +0.17%
==========================================
Files 93 93
Lines 2562 2584 +22
Branches 508 514 +6
==========================================
+ Hits 2388 2413 +25
+ Misses 155 152 -3
Partials 19 19 ☔ View full report in Codecov by Sentry. |
Carla-Moz
approved these changes
Jan 8, 2025
julienw
force-pushed
the
sort-on-main-results-page
branch
2 times, most recently
from
03af01f to
0a070f5
Compare
|
@Carla-Moz you already reviewed commits 2-4. I haven't touched them besides a rebase and conflicts, but can you please a look at commits 5 to 8 ? (Commit 1 is #839 to be reviewed indepently). Thanks! |
Carla-Moz
approved these changes
Jan 14, 2025
julienw
force-pushed
the
sort-on-main-results-page
branch
from
587cdd0 to
83718c5
Compare
Merged
julienw
added a commit
that referenced
this pull request
Jan 15, 2025
Updates: [Julien Wajsberg] Small adjustments on the sort functionality (#837) [esanuandra] PCF-562 Consider adding the OS version to the name of the platform in the "Platform" column (#816) [Carla Severe] Removed repetitive style references (#836) [Julien Wajsberg] Rename OSX to macOS to better reflect the newest naming for this platform (#840) [Julien Wajsberg] Extract the table filtering code to a common file (#839) [Julien Wajsberg] Implement sorting on the main results page (#838) [Chineta Adinnu] Add tooltips to revision column headers (#832) [Chineta Adinnu] Add aria expanded to revision row expand button (#826)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements the sorting feature on the main results page.
In the main results page the results are then processed and organized in a nested structure
test->revision->platform->result item. Therefore I was initially afraid that the sorting logic would need to be specially tailored. But instead I got the idea of doing the sort before the processing, and this seems to work just fine.deploy preview
Here is the list of commits:
summarizeVisibleRowsso that the delta value is shown can be assessed in the tests, for an easier readability in the test cases.