chore: Remove some unwraps and replace others by expect
#2294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In functions that return `Result`.
larseggert
requested review from
KershawChang,
martinthomson and
mxinden
as code owners
Failed Interop TestsQUIC Interop Runner, client vs. server, differences relative to 108fb8d. neqo-latest as client
neqo-latest as server
All resultsSucceeded Interop TestsQUIC Interop Runner, client vs. server neqo-latest as client
neqo-latest as server
Unsupported Interop TestsQUIC Interop Runner, client vs. server neqo-latest as client
neqo-latest as server
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2294 +/- ##
==========================================
- Coverage 95.31% 95.26% -0.06%
==========================================
Files 114 114
Lines 36869 36903 +34
Branches 36869 36903 +34
==========================================
+ Hits 35142 35155 +13
- Misses 1721 1742 +21
Partials 6 6 ☔ View full report in Codecov by Sentry. |
larseggert
force-pushed
the
chore-unwrap-less
branch
from
cf9783c to
c9f1896
Compare
larseggert
changed the title
unwrapsunwraps and replace others by expect
neqo-http3/src/features/extended_connect/webtransport_session.rs
Outdated
Show resolved
Hide resolved
neqo-http3/src/features/extended_connect/webtransport_session.rs
Outdated
Show resolved
Hide resolved
Co-authored-by: Martin Thomson <[email protected]> Signed-off-by: Lars Eggert <[email protected]>
Co-authored-by: Martin Thomson <[email protected]> Signed-off-by: Lars Eggert <[email protected]>
Co-authored-by: Martin Thomson <[email protected]> Signed-off-by: Lars Eggert <[email protected]>
Co-authored-by: Martin Thomson <[email protected]> Signed-off-by: Lars Eggert <[email protected]>
Benchmark resultsPerformance differences relative to 63506c5. decode 4096 bytes, mask ff: No change in performance detected. time: [11.884 µs 11.921 µs 11.965 µs]
change: [-0.7024% -0.1887% +0.2996%] (p = 0.47 > 0.05)
decode 1048576 bytes, mask ff: No change in performance detected. time: [3.0763 ms 3.0846 ms 3.0947 ms]
change: [-0.7042% -0.1744% +0.3365%] (p = 0.52 > 0.05)
decode 4096 bytes, mask 7f: No change in performance detected. time: [19.827 µs 19.870 µs 19.920 µs]
change: [-0.1739% +0.2184% +0.6397%] (p = 0.33 > 0.05)
decode 1048576 bytes, mask 7f: No change in performance detected. time: [5.1632 ms 5.1762 ms 5.1910 ms]
change: [-0.2811% +0.0961% +0.4454%] (p = 0.62 > 0.05)
decode 4096 bytes, mask 3f: No change in performance detected. time: [6.8976 µs 6.9235 µs 6.9562 µs]
change: [-0.8404% +2.1916% +7.7110%] (p = 0.57 > 0.05)
decode 1048576 bytes, mask 3f: Change within noise threshold. time: [1.7654 ms 1.7737 ms 1.7822 ms]
change: [+0.2118% +0.6898% +1.2414%] (p = 0.01 < 0.05)
coalesce_acked_from_zero 1+1 entries: No change in performance detected. time: [92.984 ns 93.363 ns 93.758 ns]
change: [-0.3746% +0.2756% +0.8701%] (p = 0.39 > 0.05)
coalesce_acked_from_zero 3+1 entries: No change in performance detected. time: [110.21 ns 110.46 ns 110.73 ns]
change: [-0.6557% -0.2186% +0.2084%] (p = 0.33 > 0.05)
coalesce_acked_from_zero 10+1 entries: No change in performance detected. time: [109.94 ns 110.45 ns 111.02 ns]
change: [-0.2525% +0.3531% +1.2091%] (p = 0.38 > 0.05)
coalesce_acked_from_zero 1000+1 entries: No change in performance detected. time: [92.486 ns 93.908 ns 97.084 ns]
change: [-1.4611% +8.1888% +26.944%] (p = 0.59 > 0.05)
RxStreamOrderer::inbound_frame(): No change in performance detected. time: [111.68 ms 111.73 ms 111.78 ms]
change: [-0.1164% +0.0947% +0.2311%] (p = 0.37 > 0.05)
SentPackets::take_ranges: No change in performance detected. time: [5.1002 µs 5.1784 µs 5.2501 µs]
change: [-16.682% -4.5942% +3.9366%] (p = 0.64 > 0.05)
transfer/pacing-false/varying-seeds: Change within noise threshold. time: [40.582 ms 40.669 ms 40.758 ms]
change: [-1.2698% -0.9854% -0.6889%] (p = 0.00 < 0.05)
transfer/pacing-true/varying-seeds: Change within noise threshold. time: [40.636 ms 40.720 ms 40.811 ms]
change: [-1.3641% -1.1002% -0.8409%] (p = 0.00 < 0.05)
transfer/pacing-false/same-seed: Change within noise threshold. time: [40.539 ms 40.622 ms 40.709 ms]
change: [-0.6251% -0.3339% -0.0504%] (p = 0.02 < 0.05)
transfer/pacing-true/same-seed: Change within noise threshold. time: [40.924 ms 41.000 ms 41.077 ms]
change: [-0.8241% -0.5735% -0.3043%] (p = 0.00 < 0.05)
1-conn/1-100mb-resp/mtu-1504 (aka. Download)/client: No change in performance detected. time: [878.89 ms 888.28 ms 898.06 ms]
thrpt: [111.35 MiB/s 112.58 MiB/s 113.78 MiB/s]
change:
time: [-0.2008% +1.4413% +3.1391%] (p = 0.09 > 0.05)
thrpt: [-3.0436% -1.4208% +0.2012%]
1-conn/10_000-parallel-1b-resp/mtu-1504 (aka. RPS)/client: No change in performance detected. time: [312.01 ms 314.07 ms 316.21 ms]
thrpt: [31.625 Kelem/s 31.840 Kelem/s 32.050 Kelem/s]
change:
time: [-1.8784% -0.9080% +0.0360%] (p = 0.07 > 0.05)
thrpt: [-0.0360% +0.9163% +1.9144%]
1-conn/1-1b-resp/mtu-1504 (aka. HPS)/client: 💔 Performance has regressed. time: [34.854 ms 35.041 ms 35.253 ms]
thrpt: [28.366 elem/s 28.538 elem/s 28.691 elem/s]
change:
time: [+1.0493% +1.7603% +2.5979%] (p = 0.00 < 0.05)
thrpt: [-2.5321% -1.7298% -1.0384%]
1-conn/1-100mb-resp/mtu-1504 (aka. Upload)/client: No change in performance detected. time: [1.6065 s 1.6229 s 1.6397 s]
thrpt: [60.988 MiB/s 61.617 MiB/s 62.246 MiB/s]
change:
time: [-2.6094% -1.2772% +0.1382%] (p = 0.08 > 0.05)
thrpt: [-0.1380% +1.2937% +2.6793%]
Client/server transfer resultsTransfer of 33554432 bytes over loopback.
|
Signed-off-by: Lars Eggert <[email protected]>
Signed-off-by: Lars Eggert <[email protected]>
Signed-off-by: Lars Eggert <[email protected]>
Signed-off-by: Lars Eggert <[email protected]>
|
@larseggert let me know once you want another review. |
Signed-off-by: Lars Eggert <[email protected]>
|
@mxinden when you have a minute, please re-review? (Not urgent.) |
Signed-off-by: Lars Eggert <[email protected]>
martinthomson
approved these changes
Feb 2, 2025
mxinden
reviewed
Feb 2, 2025
mxinden
approved these changes
Feb 2, 2025
Co-authored-by: Max Inden <[email protected]> Signed-off-by: Lars Eggert <[email protected]>
larseggert
added a commit
to larseggert/neqo
that referenced
this pull request
Feb 3, 2025
Bug in mozilla#2294 spotted by @martinthomson in 0eb7c5e#r152054928
Merged
larseggert
added a commit
that referenced
this pull request
Feb 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In functions that return
ResultorOptionor where it is easy to make them do so w/o too many other code changes.This lets us enable the clippy
unwrap_usedcheck, which is a nice reminder not to be casual withunwrap.