fix: map_or -> map_err
#2405
Merged
fix: map_or -> map_err
#2405
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bug in mozilla#2294 spotted by @martinthomson in 0eb7c5e#r152054928
larseggert
requested review from
KershawChang,
martinthomson and
mxinden
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2405 +/- ##
==========================================
- Coverage 95.26% 95.26% -0.01%
==========================================
Files 114 114
Lines 36903 36901 -2
Branches 36903 36901 -2
==========================================
- Hits 35155 35152 -3
- Misses 1742 1743 +1
Partials 6 6 ☔ View full report in Codecov by Sentry. |
Failed Interop TestsQUIC Interop Runner, client vs. server, differences relative to 108fb8d. neqo-latest as client
neqo-latest as server
All resultsSucceeded Interop TestsQUIC Interop Runner, client vs. server neqo-latest as client
neqo-latest as server
Unsupported Interop TestsQUIC Interop Runner, client vs. server neqo-latest as client
neqo-latest as server
|
Benchmark resultsPerformance differences relative to 6cdbc0c. decode 4096 bytes, mask ff: No change in performance detected. time: [11.879 µs 11.917 µs 11.961 µs]
change: [-0.5261% +0.0444% +0.6288%] (p = 0.89 > 0.05)
decode 1048576 bytes, mask ff: No change in performance detected. time: [3.0786 ms 3.0917 ms 3.1085 ms]
change: [-0.1790% +0.3189% +0.9286%] (p = 0.27 > 0.05)
decode 4096 bytes, mask 7f: No change in performance detected. time: [19.872 µs 19.928 µs 19.985 µs]
change: [-0.2982% +0.0595% +0.4111%] (p = 0.74 > 0.05)
decode 1048576 bytes, mask 7f: No change in performance detected. time: [5.1653 ms 5.1782 ms 5.1915 ms]
change: [-0.2230% +0.1239% +0.4761%] (p = 0.49 > 0.05)
decode 4096 bytes, mask 3f: No change in performance detected. time: [6.9183 µs 6.9538 µs 6.9961 µs]
change: [-0.0614% +0.8580% +2.2754%] (p = 0.14 > 0.05)
decode 1048576 bytes, mask 3f: 💔 Performance has regressed. time: [1.7821 ms 1.7945 ms 1.8083 ms]
change: [+1.3363% +2.0426% +2.9828%] (p = 0.00 < 0.05)
coalesce_acked_from_zero 1+1 entries: No change in performance detected. time: [92.926 ns 93.229 ns 93.525 ns]
change: [-0.5210% -0.1225% +0.2660%] (p = 0.55 > 0.05)
coalesce_acked_from_zero 3+1 entries: No change in performance detected. time: [110.42 ns 110.72 ns 111.05 ns]
change: [-0.5530% -0.0170% +0.4112%] (p = 0.95 > 0.05)
coalesce_acked_from_zero 10+1 entries: No change in performance detected. time: [109.93 ns 110.30 ns 110.77 ns]
change: [-0.3726% +0.1939% +0.7723%] (p = 0.53 > 0.05)
coalesce_acked_from_zero 1000+1 entries: No change in performance detected. time: [92.527 ns 92.652 ns 92.796 ns]
change: [-0.3011% +0.5288% +1.3582%] (p = 0.22 > 0.05)
RxStreamOrderer::inbound_frame(): Change within noise threshold. time: [111.59 ms 111.65 ms 111.72 ms]
change: [-0.2844% -0.2021% -0.1195%] (p = 0.00 < 0.05)
SentPackets::take_ranges: :broken_heart: Performance has regressed. time: [5.2137 µs 5.3988 µs 5.5934 µs]
change: [+1.0854% +5.1999% +10.569%] (p = 0.02 < 0.05)
transfer/pacing-false/varying-seeds: Change within noise threshold. time: [39.695 ms 39.788 ms 39.895 ms]
change: [-2.3310% -2.0334% -1.7252%] (p = 0.00 < 0.05)
transfer/pacing-true/varying-seeds: Change within noise threshold. time: [39.787 ms 39.866 ms 39.949 ms]
change: [-1.7405% -1.4857% -1.2337%] (p = 0.00 < 0.05)
transfer/pacing-false/same-seed: Change within noise threshold. time: [39.345 ms 39.426 ms 39.514 ms]
change: [-3.1461% -2.8484% -2.5436%] (p = 0.00 < 0.05)
transfer/pacing-true/same-seed: Change within noise threshold. time: [39.735 ms 39.808 ms 39.889 ms]
change: [-2.1782% -1.9308% -1.6728%] (p = 0.00 < 0.05)
1-conn/1-100mb-resp/mtu-1504 (aka. Download)/client: 💚 Performance has improved. time: [858.01 ms 867.84 ms 877.98 ms]
thrpt: [113.90 MiB/s 115.23 MiB/s 116.55 MiB/s]
change:
time: [-4.3675% -2.7820% -1.0611%] (p = 0.00 < 0.05)
thrpt: [+1.0725% +2.8616% +4.5670%]
1-conn/10_000-parallel-1b-resp/mtu-1504 (aka. RPS)/client: No change in performance detected. time: [314.26 ms 316.42 ms 318.64 ms]
thrpt: [31.383 Kelem/s 31.604 Kelem/s 31.821 Kelem/s]
change:
time: [-1.1404% -0.1858% +0.7214%] (p = 0.70 > 0.05)
thrpt: [-0.7162% +0.1862% +1.1535%]
1-conn/1-1b-resp/mtu-1504 (aka. HPS)/client: No change in performance detected. time: [33.970 ms 34.114 ms 34.264 ms]
thrpt: [29.185 elem/s 29.313 elem/s 29.437 elem/s]
change:
time: [-1.3450% -0.6569% +0.0515%] (p = 0.06 > 0.05)
thrpt: [-0.0515% +0.6612% +1.3633%]
1-conn/1-100mb-resp/mtu-1504 (aka. Upload)/client: Change within noise threshold. time: [1.5826 s 1.5988 s 1.6151 s]
thrpt: [61.914 MiB/s 62.549 MiB/s 63.189 MiB/s]
change:
time: [-2.7903% -1.4257% -0.0412%] (p = 0.05 < 0.05)
thrpt: [+0.0412% +1.4463% +2.8704%]
Client/server transfer resultsTransfer of 33554432 bytes over loopback.
|
martinthomson
approved these changes
Feb 3, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug in #2294 spotted by @martinthomson in larseggert@0eb7c5e#r152054928