Move datagrams below regular streams #1447
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will starve datagrams, which comes with its own risks. Eventually, we'll need a better strategy.
KershawChang
approved these changes
Jun 28, 2023
|
LGTM. Both ways work. |
|
Hi @martinthomson , I am a bit confused about this patch. |
|
@martinthomson , could you resolve the conflicts of this patch? |
|
The blocker here is tests. Neither patch includes tests and I really don't like having functionality that isn't tested. |
Ah, I see. I'll write a test for this. |
Merged
|
I think that we got the tests in #1440, so I'm closing this one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will starve datagrams, which comes with its own risks.
Eventually, we'll need a better strategy.
@jesup is this a better starting for #1440?