add test #1450
Merged
add test #1450
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martinthomson
requested changes
Jul 8, 2023
|
|
||
| // Create a stream and send some data. | ||
| let stream_id = client.stream_create(StreamType::BiDi).unwrap(); | ||
| client.stream_send(stream_id, &[6; 100]).unwrap(); |
There was a problem hiding this comment.
Ok, so is the datagram too big to fit in a packet that has this stream data as well? I'd send a little more to ensure that is the case.
If it is, then that is good. Then you want to:
- have the client create two packets. the first should be smaller than the datagram size, which you can check
- have the server process the first. it should receive stream data, but not a datagram event
- have the server process the second. it should receive the datagram event then
We probably shouldn't rely on the order of events here. That's not something we'd want to promise in the API unless we really had to (and we don't).
Then add another test that sends low priority stream data first and observe the opposite inversion.
|
Note that we're also seeing this new test fail. |
This will starve datagrams, which comes with its own risks. Eventually, we'll need a better strategy.
I'll push a new commit that includes every thing to make the test pass. |
KershawChang
force-pushed
the
datagram_after_stream_data
branch
from
185ddc1 to
08a5001
Compare
martinthomson
approved these changes
Jul 16, 2023
KershawChang
force-pushed
the
datagram_after_stream_data
branch
from
a9c1009 to
92724e8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the test for #1447