-
Notifications
You must be signed in to change notification settings - Fork 176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor content panels into an iframe #840
Changes from 8 commits
10495ec
6e2ba45
7a473f4
84f9999
6b66748
a2e1a59
70fba62
52d5ad1
81b5f21
e96e59c
3043993
9947f47
53012b3
f40d075
5e9bcfc
a79901d
4db8505
478e613
d5ca6b2
ad4eb4a
c07e173
de2a237
c125976
e14401f
c39642f
3cc76d3
3cdab59
8beb37c
9da6a46
e1cf345
201b1fc
3877556
78d7ee5
f8c4802
6208ebd
fc0f748
752240e
18ff4cc
123432b
e50d9ee
5043efb
bcbb8f3
75ce8b8
1ddf56a
36a5fcc
f25957b
59e1fbd
2617414
44a0564
a8394ed
00ded76
d167b91
0e80d3b
cd3a362
0f3d997
43fbe67
d00f570
3ea4a3d
71c6a4c
a84bda9
df76c4c
bdf9ede
8cfe164
75dbf5d
c1fae24
9503ba9
4b365b6
0a16393
c4bb69e
f378fe0
7380fcc
db97336
fc57e91
06bca44
c0b0312
662c829
5b69470
964d6d9
9d0526d
c1eadd1
6cab065
2b141da
b1824bd
20c6d70
e3f0d46
2c8a5ae
c6fc27d
c5e0355
218c23d
d73fd97
44a944f
811547e
9405235
279c575
3da9492
84419e0
a039288
d809e84
2d9a990
49eedf9
c1ad9dc
6a79742
40ed81e
ce7db08
a94c1de
97fad57
80720a1
7d2e7d9
0515b65
7a91563
39030d7
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change | ||
---|---|---|---|---|
@@ -1,3 +1,17 @@ | ||||
|
||||
|
||||
body { | ||||
--blue60: #0060df; | ||||
--blue70: #003eaa; | ||||
--primaryText: #0c0c0d; | ||||
--secondaryText: #737373; | ||||
--grey20: #ededf0; | ||||
--transition: all .15s cubic-bezier(.07,.95,0,1); | ||||
--borders: 1px solid #ededf0; | ||||
font-family: "SF Pro Text", 'Segoe UI', Roboto, Oxygen, Ubuntu, Cantarell, 'Open Sans', 'Helvetica Neue', sans-serif; | ||||
overflow: hidden; | ||||
} | ||||
|
||||
/* Button Replacement */ | ||||
.fbc-loginButton { | ||||
background-size: contain; | ||||
|
@@ -47,7 +61,7 @@ | |||
.fbc-badge { | ||||
all: initial; | ||||
position: absolute; | ||||
z-index: 100; | ||||
z-index: 999999999999999; | ||||
transition: opacity 0.2s ease-out; | ||||
font-family: "SF Pro Text", 'Segoe UI', Roboto, Oxygen, Ubuntu, Cantarell, 'Open Sans', 'Helvetica Neue', sans-serif !important; | ||||
--transition: all .15s cubic-bezier(.07,.95,0,1); | ||||
|
@@ -125,20 +139,35 @@ | |||
opacity: 1; | ||||
} | ||||
|
||||
.fbc-badge-prompt { | ||||
display: none; | ||||
width: 345px; | ||||
.fbc-wrapper{ | ||||
position: fixed; | ||||
height: 100%; | ||||
top: 0; | ||||
bottom: 0; | ||||
left: 0; | ||||
right: 0; | ||||
width: 100%; | ||||
z-index: 999999999999; | ||||
background-color: rgba(0, 0, 0, 0.1); | ||||
/* animation: 0.2s ease forwards; */ | ||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. nit: Remove commented code
Suggested change
|
||||
} | ||||
|
||||
.fbc-wrapper iframe { | ||||
/* position: absolute; */ | ||||
|
||||
/* width: 345px; | ||||
position: absolute; | ||||
left: calc( 100% + 20px); | ||||
top: 50%; | ||||
transform: translateY(-50%); | ||||
transform: translateY(-50%); */ | ||||
color: var(--black); | ||||
box-shadow: 0 5px 12px 0 rgba(0,0,0,0.2); | ||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. polish (non-blocking): Can we make |
||||
border: 1px solid rgba(0,0,0,0.2); | ||||
padding: 0 0 40px; | ||||
background: rgb(235, 235, 235); | ||||
} | ||||
|
||||
.fbc-badge-prompt:after { | ||||
iframe::after { | ||||
content: " "; | ||||
position: absolute; | ||||
left: -10px; | ||||
|
@@ -151,33 +180,33 @@ | |||
border-color: transparent var(--white) transparent; | ||||
} | ||||
|
||||
.fbc-badge-prompt-align-right .fbc-badge-prompt { | ||||
.fbc-badge-prompt-align-right iframe { | ||||
left: auto; | ||||
right: calc( 100% + 20px); | ||||
} | ||||
|
||||
.fbc-badge-prompt-align-right .fbc-badge-prompt:after { | ||||
.fbc-badge-prompt-align-right iframe { | ||||
left: auto; | ||||
right: -10px; | ||||
border-width: 10px 0 10px 10px; | ||||
} | ||||
|
||||
.fbc-badge-prompt-align-top .fbc-badge-prompt { | ||||
.fbc-badge-prompt-align-top iframe { | ||||
top: -7px; | ||||
transform: none; | ||||
} | ||||
|
||||
.fbc-badge-prompt-align-top .fbc-badge-prompt:after { | ||||
.fbc-badge-prompt-align-top iframe:after { | ||||
top: 16px; | ||||
} | ||||
|
||||
.fbc-badge-prompt-align-bottom .fbc-badge-prompt { | ||||
.fbc-badge-prompt-align-bottom iframe { | ||||
top: auto; | ||||
bottom: -20px; | ||||
transform: none; | ||||
} | ||||
|
||||
.fbc-badge-prompt-align-bottom .fbc-badge-prompt:after { | ||||
.fbc-badge-prompt-align-bottom iframe:after { | ||||
display: none; | ||||
} | ||||
|
||||
|
@@ -257,11 +286,12 @@ | |||
} | ||||
|
||||
.fbc-badge-prompt-buttons { | ||||
position: absolute; | ||||
bottom: 0.15px; | ||||
height: 40px; | ||||
width: 100%; | ||||
z-index: 0; | ||||
display: flex; | ||||
gap: 16px; | ||||
} | ||||
|
||||
.fbc-badge-prompt-buttons button { | ||||
|
@@ -347,3 +377,7 @@ | |||
right: -10px; | ||||
border-width: 10px 0 10px 10px; | ||||
} */ | ||||
|
||||
.is-hidden { | ||||
display: none; | ||||
} | ||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. praise: Nice utility class usage! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
question: Is this z-index necessary, or just an artifact from Relay's CSS?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just reverted it back to its previous value and I didn't see a difference, it might've been just an artifact like you said.