Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GLAM filter out versions above latest #5868

Merged
merged 2 commits into from
Jul 2, 2024
Merged

GLAM filter out versions above latest #5868

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
98886cb
GLAM filter out versions above latest
edugfilho Jun 28, 2024
dd30cba
Merge branch 'main' into glam-dont-aggregate-weird-versions
edugfilho Jul 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion bigquery_etl/glam/templates/clients_histogram_aggregates_v1.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
-- only keep builds from the last year
AND {{ build_date_udf }}(app_build_id) > DATE_SUB(@submission_date, INTERVAL 365 day)
{% if filter_version %}
AND app_version > (latest_version - {{ num_versions_to_keep }})
AND app_version BETWEEN (latest_version - {{ num_versions_to_keep }}) AND latest_version
{% endif %}
{% endset %}

Expand Down
2 changes: 1 addition & 1 deletion bigquery_etl/glam/templates/clients_scalar_aggregates_v1.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
-- only keep builds from the last year
AND {{ build_date_udf }}(app_build_id) > DATE_SUB(@submission_date, INTERVAL 365 day)
{% if filter_version %}
AND app_version > (latest_version - {{ num_versions_to_keep }})
AND app_version BETWEEN (latest_version - {{ num_versions_to_keep }}) AND latest_version
{% endif %}
{% endset %}

Expand Down