Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GLAM filter out versions above latest #5868

Merged
merged 2 commits into from
Jul 2, 2024

Conversation

edugfilho
Copy link
Contributor

@edugfilho edugfilho commented Jun 28, 2024

Weird versions like 999 and 1024 are part of the reason why it's hard to analyze graphs for some Glean metrics. This PR ensures that the ETL won't process versions above the latest_version.
I'll manually remove data with invalid versions from the current production dataset.

Checklist for reviewer:

  • Commits should reference a bug or github issue, if relevant (if a bug is referenced, the pull request should include the bug number in the title).
  • If the PR comes from a fork, trigger integration CI tests by running the Push to upstream workflow and provide the <username>:<branch> of the fork as parameter. The parameter will also show up
    in the logs of the manual-trigger-required-for-fork CI task together with more detailed instructions.
  • If adding a new field to a query, ensure that the schema and dependent downstream schemas have been updated.
  • When adding a new derived dataset, ensure that data is not available already (fully or partially) and recommend extending an existing dataset in favor of creating new ones. Data can be available in the bigquery-etl repository, looker-hub or in looker-spoke-default.

For modifications to schemas in restricted namespaces (see CODEOWNERS):

┆Issue is synchronized with this Jira Task

@edugfilho edugfilho merged commit 16a1d44 into main Jul 2, 2024
20 of 21 checks passed
@edugfilho edugfilho deleted the glam-dont-aggregate-weird-versions branch July 2, 2024 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants