-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Message Screeens #57
Merged
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
f077751
WIP WIP
strseb 0001146
Add prefab screens for subcribenow, signin, install
strseb b3d79f6
test conditional-view
strseb 5aec709
more commands and more formatting
strseb 6bf4bfe
fix state
strseb 878976f
fixes
strseb 552dc34
revert
strseb File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,49 @@ | ||
/* This Source Code Form is subject to the terms of the Mozilla Public | ||
* License, v. 2.0. If a copy of the MPL was not distributed with this | ||
* file, You can obtain one at http://mozilla.org/MPL/2.0/. */ | ||
|
||
import { html, LitElement } from "../vendor/lit-all.min.js"; | ||
|
||
/** | ||
* `ConditionalView` | ||
* | ||
* Takes N elements each with a slot="" attribute, | ||
* the active rendered view can be controlled using slotName="slot" | ||
* if no view matches "slotName" the slot named "default" will be rendered. | ||
* | ||
* | ||
* <conditional-view slotName="b"> | ||
* <h1 slot="a">Hidden</h1> | ||
* <h1 slot="b">This is rendered</h1> | ||
* </conditional-view> | ||
*/ | ||
|
||
export class ConditionalView extends LitElement { | ||
static properties = { | ||
slotName: { reflect: true }, | ||
}; | ||
constructor() { | ||
super(); | ||
this.slotName = "default"; | ||
} | ||
|
||
hasSlot(slotName) { | ||
return Array.from(this.children).some((e) => { | ||
return e.slot === slotName; | ||
}); | ||
} | ||
getTargetSlot() { | ||
const slot = this.slotName; | ||
if (slot == "") { | ||
return "default"; | ||
} | ||
if (!this.hasSlot(slot)) { | ||
return "default"; | ||
} | ||
return slot; | ||
} | ||
render() { | ||
return html` <slot name=${this.getTargetSlot()}></slot> `; | ||
} | ||
} | ||
customElements.define("conditional-view", ConditionalView); |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IIUC blank slot names should be caught at check at L40 which also returns "default" so I don't think we need this block.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You could have a subelement with slot="" and therefore match slotName="".
Also just no need to iterate over the children if it is empty, as i want it to use "default" in that case.