Add Message Screeens #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lesleyjanenorton
approved these changes
Sep 10, 2024
| let slot = this.slotName; | ||
| if (slot == "") { | ||
| return "default"; | ||
| } |
There was a problem hiding this comment.
IIUC blank slot names should be caught at check at L40 which also returns "default" so I don't think we need this block.
There was a problem hiding this comment.
You could have a subelement with slot="" and therefore match slotName="".
Also just no need to iterate over the children if it is empty, as i want it to use "default" in that case.
src/components/message-screen.js
Outdated
Comment on lines
43
to
57
| hasSlot(slotName) { | ||
| return Array.from(this.children).some((e) => { | ||
| e.slot === slotName; | ||
| }); | ||
| } | ||
| getTargetSlot() { | ||
| let slot = this.slotName; | ||
| if (slot == "") { | ||
| return "default"; | ||
| } | ||
| if (!this.hasSlot(slot)) { | ||
| return "default"; | ||
| } | ||
| return slot; | ||
| } |
There was a problem hiding this comment.
Do we need hasSlot() and getTargetSlot() here too?
There was a problem hiding this comment.
hahaha spotted copy pasting
There was a problem hiding this comment.
i really should setup a macro in my editor to create lit components 😅
There was a problem hiding this comment.
It can be our first extension devtool! 🛠️
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a view-router we can use to switch out the browser action main element based on ... things.
Also i add a generic message-screen factory, so we can simply add more with one func call :)
followMessages.mp4