Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small linting fixes #287

Merged
merged 5 commits into from
Oct 29, 2024
Merged

Small linting fixes #287

merged 5 commits into from
Oct 29, 2024

Conversation

pkqk
Copy link
Member

@pkqk pkqk commented Oct 24, 2024

@pkqk pkqk requested a review from a team as a code owner October 24, 2024 21:13
pkqk added 5 commits October 29, 2024 15:35
len() of a nil slice returns 0 so the double check is unecessary.
Cleans up a lint warning, probably wouldn't be an issue unless a
malicious `error` returned a weird string.
The error message provides no extra value, the original error provides
plenty of detail for example:

  Post "http://service.name:80/query": dial tcp 172.1.2.3:80: connect: connection refused
@pkqk pkqk merged commit f65f555 into main Oct 29, 2024
6 checks passed
@pkqk pkqk deleted the lints branch October 29, 2024 02:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant