Skip to content

Commit

Permalink
Remove loop variable aliasing prevention
Browse files Browse the repository at this point in the history
This issue is fixed in go1.22
https://tip.golang.org/doc/go1.22#language
  • Loading branch information
pkqk committed Oct 24, 2024
1 parent 285b0d4 commit fc20027
Showing 1 changed file with 1 addition and 3 deletions.
4 changes: 1 addition & 3 deletions executable_schema.go
Original file line number Diff line number Diff line change
Expand Up @@ -103,9 +103,7 @@ func (s *ExecutableSchema) UpdateSchema(ctx context.Context, forceRebuild bool)
// Avoid fetching more than 64 servides in parallel,
// as high concurrency can actually hurt performance
group.SetLimit(64)
for url_, s_ := range s.Services {
url := url_
s := s_
for url, s := range s.Services {
group.Go(func() error {
logger := log.WithField("url", url)
updated, err := s.Update(ctx)
Expand Down

0 comments on commit fc20027

Please sign in to comment.