Skip to content

removed duplicate imports #1211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

removed duplicate imports #1211

wants to merge 2 commits into from

Conversation

jeoseo
Copy link
Contributor

@jeoseo jeoseo commented May 5, 2022

Description

Learning how to contribute to open source repositories for a class, referred to this issue: #818. On a side note, the tests for moveit_servo seem to fail because they rely on moveit_configs_utils, which has a problem as seen here: ament/ament_cmake#382.

Checklist

  • Required by CI: Code is auto formatted using clang-format
  • Extend the tutorials / documentation reference
  • Document API changes relevant to the user in the MIGRATION.md notes
  • Create tests, which fail without this PR reference
  • Include a screenshot if changing a GUI
  • While waiting for someone to review your request, please help review another open pull request to support the maintainers

Copy link
Member

@JafarAbdi JafarAbdi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like you mixed two patches, please revert the changes to moveit_core/planning_scene/src/planning_scene.cpp

@codecov
Copy link

codecov bot commented May 10, 2022

Codecov Report

Merging #1211 (7d75c5a) into main (59a1307) will decrease coverage by 4.10%.
The diff coverage is 76.98%.

@@            Coverage Diff             @@
##             main    #1211      +/-   ##
==========================================
- Coverage   60.16%   56.07%   -4.09%     
==========================================
  Files         274      265       -9     
  Lines       24830    24357     -473     
==========================================
- Hits        14937    13655    -1282     
- Misses       9893    10702     +809     
Impacted Files Coverage Δ
...llision_detection/src/collision_octomap_filter.cpp 0.00% <0.00%> (ø)
.../collision_detection_fcl/src/collision_env_fcl.cpp 91.52% <ø> (ø)
...ory_processing/iterative_spline_parameterization.h 100.00% <ø> (ø)
...ctory_processing/iterative_time_parameterization.h 100.00% <ø> (ø)
...ry_processing/time_optimal_trajectory_generation.h 100.00% <ø> (ø)
...veit/trajectory_processing/time_parameterization.h 100.00% <ø> (ø)
...ocessing/src/iterative_spline_parameterization.cpp 84.46% <0.00%> (-1.07%) ⬇️
...processing/src/iterative_time_parameterization.cpp 91.99% <0.00%> (-1.32%) ⬇️
...ccupancy_map_monitor/src/occupancy_map_monitor.cpp 20.13% <ø> (ø)
...ics_plugin_loader/src/kinematics_plugin_loader.cpp 69.75% <ø> (ø)
... and 58 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d482c1d...7d75c5a. Read the comment docs.

@vatanaksoytezer
Copy link
Contributor

@jeoseo seems launch_ros is actually needed.

@jeoseo
Copy link
Contributor Author

jeoseo commented May 17, 2022

It seems like these imports are necessary, unlike what #818 seemed to say, closing PR.

@jeoseo jeoseo closed this May 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants