Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add charmm_writer and change import in 3x3x1.0-3 nvt build #39

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

rmatsum836
Copy link
Collaborator

Addresses #38.

@rmatsum836
Copy link
Collaborator Author

If this looks okay, we can go ahead and change the rest of the import statements to import charmm_writer from the utils directory.

@justinGilmer
Copy link
Collaborator

Looks good to me, havent tested heavily though.

Also, here is a one-liner to find all instances and replace, assuming you are in the top level of mosdef_slitpore. Note that this works with the sed program that ships with MacOS (BSD-flavored sed).

grep -rl "import mbuild.formats.charmm_writer as mf_charmm" .  | xargs sed -i '' -e 's/import\ mbuild\.formats\.charmm\_writer\ as\ mf\_charmm/from\ mosdef\_slitpore\.utils\ import\ charmm\_writer\ as\ mf\_charmm/'

Uses bash to just find the files where the pattern occurs, passes the file locations as arguments (thanks to xargs) to the sed command. Just verify the diff afterwards. It looks good on my side.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants