Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

These are the added instructions to run the MoSDeF builds for GOMC a… #45

Merged
merged 4 commits into from
Nov 22, 2020

Conversation

bc118
Copy link
Collaborator

@bc118 bc118 commented Nov 7, 2020

This PR contains the modified MoSDeF build files and the modified GOMC run files that work in the new directory structure. Also, there are instructions (Readme) files that walk the user thru how to run the MoSDeF code and the GOMC simulations, which are provided in every major section.

simulations/nvt-pore/1x1x1.0nm_1-layer/gomc/README.md Outdated Show resolved Hide resolved
* module_load_command_3 = Add your HPC specific module command here as a string or set as None

4) Run the python build script simbuild.py
* python simbuild.py
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you use markdown for the python commands like python simbuild.py?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought this would print nice on the github page when you are viewing it though there. If you still want me to change it I can.

* "full_path_to_GOMC_bin_folder"/GOMC_CPU_NVT +p2 in.conf > out.dat

Alternatively, Run the code using the CPU/GPU:
* "full_path_to_GOMC_bin_folder"/GOMC_GPU_NVT +p2 in.conf > out.dat
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as markdown comment above.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought this would print nice on the github page when you are viewing it though there. If you still want me to change it I can.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it will still look nice with the bullet point. Something like:

  • "full_path_to_GOMC_bin_folder"/GOMC_GPU_NVT +p2 in.conf > out.dat

Just to distinguish it from the rest of the text. Let me know what you think.

Copy link
Collaborator Author

@bc118 bc118 Nov 12, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry I guess I'm confused. I took the format from the mosdef_slitpore/README.md file. Which appeared to print bullet points in the GitHub page when presented as with the '*" symbol. When I preview this example here below it prints a bullet point in preview mode. Do you mean when viewing the hard file and not via GitHub? Or just mean that they should be indented?

Example:

  1. Change the terminal window directory to the set1 directory (i.e., to mosdef_slitpore/mosdef_slitpore/simulations/nvt-pore/1x1x1.0nm_1-layer/gomc/set1).
  • cd ../set1

… required file and functions in that one file. Changed the GOMC file builders to run off this.
Copy link
Collaborator

@rmatsum836 rmatsum836 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

water.energy_minimization is deprecated in mBuild and is raising an error for me. You can swap this out with water.energy_minimize()

@rmatsum836 rmatsum836 merged commit 1c50b59 into mosdef-hub:master Nov 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants