Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PCI framework refactor: part 1 #1212

Merged
merged 2 commits into from
Apr 6, 2024
Merged

Conversation

AnErrupTion
Copy link
Collaborator

Howdy! This PR is the first part of refactoring the PCI subsystem in the device driver framework to increase code readability and thus decrease code "spaghettiness". Here are the changes done in this first part:

  • Remove IPCIControllerLegacy because it was unused
  • Remove PCIDeviceConfiguration because it was only used by the PCIControllerService and the PCIDeviceService
  • Added a constructor in the PCIDevice class a constructor which allows setting the bus, slot and function of the device
  • The PCICommand and the PCIConfigurationHeader structs have been split from the PCIDevice class
  • The DeviceService.Initialize() method was added to initialize generic device drivers
  • The PCIControllerService and the PCIDeviceService were merged into one service

@AnErrupTion AnErrupTion self-assigned this Apr 5, 2024
@tgiphil tgiphil merged commit 26c9b72 into mosa:master Apr 6, 2024
66 checks passed
@AnErrupTion AnErrupTion deleted the pci-refactor-1 branch April 6, 2024 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants