Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is the second part of #1212 and focuses on more changes within the PCI subsystem. The following changes were done:
ISABus
device driver was removed in favor of anISADeviceService
PCIField.All
to include all fields in the enum at onceBusType
property inDevice
, which is set to theDeviceDriverRegistryEntry
'sBusType
by defaultPCIDevice
:VendorID
andDeviceID
are now retrieved onceDeviceDriverRegistryEntry.Factory
is now checked for nullability, and same for theBaseDeviceDriver
instantiated by itDeviceService.GetAllDevices(DeviceBusType)
method as a way to get all devices by a specific bus type, e.g. ISA or PCI. This unifies the process, instead of having to check forISABus
orPCIDevice
respectivelyPCIDeviceService
:Initialize()
method, where it finds for the first initializedIPCIController
Device
. This allows for retrieving unknown PCI devices using the newly addedDeviceService.GetAllDevices(DeviceBusType)
method, instead of getting all devices that inherit fromPCIDevice