Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #201 - authorize empty search #202

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
+10 −2
Open

Fix #201 - authorize empty search #202

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions src/Controller/SearchController.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@
namespace MonsieurBiz\SyliusSearchPlugin\Controller;

use MonsieurBiz\SyliusSearchPlugin\Exception\UnknownRequestTypeException;
use MonsieurBiz\SyliusSearchPlugin\Form\Type\SearchType;
use MonsieurBiz\SyliusSearchPlugin\Model\Documentable\DocumentableInterface;
use MonsieurBiz\SyliusSearchPlugin\Search\Request\RequestConfiguration;
use MonsieurBiz\SyliusSearchPlugin\Search\Request\RequestInterface;
Expand Down Expand Up @@ -98,8 +99,15 @@ public function searchAction(
*/
public function postAction(Request $request): RedirectResponse
{
$query = (array) ($request->request->all()['monsieurbiz_searchplugin_search'] ?? []);
$query = $query['query'] ?? '';
$form = $this->createForm(SearchType::class);
$form->handleRequest($request);
if (!$form->isSubmitted() || !$form->isValid()) {
throw $this->createNotFoundException();
}

/** @var array $data */
$data = $form->getData();
$query = $data['query'] ?? '';

// With Apache a URL with a encoded slash (%2F) is provoking a 404 error on the server level
return $this->redirect(
Expand Down
Loading