Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #201 - authorize empty search #202

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix #201 - authorize empty search #202

wants to merge 1 commit into from
+10 −2

Conversation

cbastienbaron
Copy link
Contributor

@cbastienbaron cbastienbaron commented Dec 15, 2023 •
edited by delyriand
Loading

Fixed #201

image

maximehuran
maximehuran reviewed Sep 23, 2024
View reviewed changes
Copy link
Member

@maximehuran maximehuran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do you want to allow empty search ?

@delyriand delyriand mentioned this pull request Sep 23, 2024
Open
delyriand
delyriand requested changes Sep 23, 2024
View reviewed changes
Copy link
Member

@delyriand delyriand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎯 suggestion: See my comment in the issue #201 (comment), i suggest to throw a NotFoundException in the postAction‏

@lanfisis lanfisis removed their request for review October 1, 2024 13:55
maximehuran
maximehuran reviewed Oct 1, 2024
View reviewed changes
Copy link
Member

@maximehuran maximehuran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do you want to allow empty search ?
What is the goal of that ?

@cbastienbaron
Copy link
Contributor Author

Why do you want to allow empty search ? What is the goal of that ?

just to avoid an error see #201

@Kiwikoti Kiwikoti removed their request for review October 28, 2024 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maximehuran maximehuran maximehuran left review comments

@delyriand delyriand delyriand approved these changes

Assignees
No one assigned
Labels
Status: needs review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[error] - monsieurbiz_search_search with POST empty throw 500
4 participants
@cbastienbaron @delyriand @maximehuran @madamebiz