MONGOID-5608 allow using #exists? with args on relations
#5736
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| # @return [ true | false ] True is persisted documents exist, false if not. | ||
| def exists? | ||
| criteria.exists? | ||
| def exists?(id_or_conditions = :none) |
There was a problem hiding this comment.
Why not:
delegate :exists?, to: :criteria
There was a problem hiding this comment.
That would work, too. In general I'm not a fan of that style. It tends to stymie investigation into execution flow, at least for me. I'll think about it, though.
There was a problem hiding this comment.
It is recommended by Rubocop: https://docs.rubocop.org/rubocop-rails/cops_rails.html#railsdelegate
comandeo
approved these changes
Nov 2, 2023
comandeo
approved these changes
Nov 2, 2023
jamis
added a commit
that referenced
this pull request
Nov 2, 2023
…5738) * MONGOID-5608 allow using `#exists?` with args on relations * simplify * test the nil/false and _id matching paths, too
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds extended support for
#exists?onembeds_manyandhas_manyassociations, so the API is the same as is present elsewhere in Mongoid, where the#exists?accepts conditions that can be used to narrow the scope of the query.