Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MONGOID-5608 allow using #exists? with args on relations (Backport to 8.0-stable) #5739

Closed
wants to merge 1 commit into from
Closed

MONGOID-5608 allow using #exists? with args on relations (Backport to 8.0-stable) #5739

wants to merge 1 commit into from

Conversation

jamis
Copy link
Contributor

@jamis jamis commented Nov 2, 2023

@jamis
MONGOID-5608 allow using #exists? with args on relations (mongodb#5736
1a3efa4 
)

* MONGOID-5608 allow using `#exists?` with args on relations

* simplify

* test the nil/false and _id matching paths, too
@jamis jamis requested a review from comandeo November 2, 2023 16:08
@jamis
Copy link
Contributor Author

jamis commented Nov 2, 2023

Actually, I'm going to close this without merging, since MONGOID-5100 (which added the extra arguments to #exists?) only targeted 8.1. 8.0 continues to have only the 0-arity #exists? implementation.

@jamis jamis closed this Nov 2, 2023
@jamis jamis deleted the 5608-exists-with-args-on-relations-8.0 branch June 26, 2024 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@comandeo comandeo comandeo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jamis @comandeo