Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MAXO annotation evaluation #259

Merged
merged 23 commits into from
Nov 17, 2023
Merged

Add MAXO annotation evaluation #259

merged 23 commits into from
Nov 17, 2023

Conversation

caufieldjh
Copy link
Member

No description provided.

@caufieldjh
Copy link
Member Author

Not quite there yet - need to account for partial matches since these all test relations are stored as one-to-one triples but extracted are still one-to-many.
Also labeling isn't working as expected.
Also predicates may not be filtered correctly (all test triples have TREATS as predicate)

@caufieldjh
Copy link
Member Author

This still has some strangeness going on with parsing of ungrounded results but otherwise works.
Needs more of the test cases to be included before it's ready.

@caufieldjh
Copy link
Member Author

One remaining bit of weirdness: the extracted predicate is sometimes IS USED TO TREAT rather than TREATS, which is semantically identical but may be the tip of an iceberg of ungrounded predicate variations.

@caufieldjh caufieldjh marked this pull request as ready for review November 17, 2023 00:39
@caufieldjh
Copy link
Member Author

Trying this out on all available test sets before merging. It will likely need some more work after that, but some of that work will concern improving the extraction template.

@caufieldjh
Copy link
Member Author

One last bit of weirdness: the parsed triples can sometimes get populated with invalid values, despite starting as fully valid objects.
For example, this action_to_symptom relation:

        - subject: MAXO:0001175
          predicate: IS USED TO TREAT
          object:
            - end-stage liver disease
          qualifier:
          subject_qualifier:
          object_qualifier:

becomes this mostly-empty triple:

        - subject: end-stage liver disease
          predicate:
          object:
          qualifier:
          subject_qualifier:
          object_qualifier:

It shouldn't even be in the triples in the first place as the symptom isn't grounded to HP, so perhaps a boolean is flipped somewhere.

@caufieldjh caufieldjh merged commit 7ffc61a into main Nov 17, 2023
2 checks passed
@caufieldjh caufieldjh deleted the eval_maxo branch November 17, 2023 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant