Apply media viewer already created fixes to develop #1252
Merged
+134
−77
Commits on Sep 25, 2024
-
-
Use new objc AVURLAsset generator for chat video cells
This makes sure we get rid of the non-public symbol previously used.
-
-
Open swipe view with selected image in chat view
For now, we only provide the currently selected image, so there is no change in user experience. But we will want to enable multiple images in a future commit.
-
-
-
Only show media button if there's media to view
We also move the media gallery button above the "show shared media and files" one as users will generally prefer the media gallery.
-
Rename buttons to open media and files
Make the wording consistent with other buttons in the list (only use nouns, no verbs). Shorten the wording and hopefully make it more clear to users the difference between the two.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.