Apply media viewer already created fixes to develop #1252
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes sure we get rid of the non-public symbol previously used.
For now, we only provide the currently selected image, so there is no change in user experience. But we will want to enable multiple images in a future commit.
We also move the media gallery button above the "show shared media and files" one as users will generally prefer the media gallery.
Make the wording consistent with other buttons in the list (only use nouns, no verbs). Shorten the wording and hopefully make it more clear to users the difference between the two.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit applies the fixes originally made in #1221
It contains fixes for the media gallery: #1251