Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stdlib] Simplify bit.mojo #4210

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[stdlib] Simplify bit.mojo #4210

wants to merge 1 commit into from
+2 −5

Conversation

soraros
Copy link
Contributor

@soraros soraros commented Mar 30, 2025

Do we even want/need a bit.bit_not?

@soraros soraros requested a review from a team as a code owner March 30, 2025 00:46
JoeLoser
JoeLoser approved these changes Mar 31, 2025
View reviewed changes
Copy link
Collaborator

@JoeLoser JoeLoser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's keep bit_not for now, but I agree, it has little value given that ~val is well-formed where val is a SIMD type.

@JoeLoser
Copy link
Collaborator

!sync

@modularbot modularbot added the imported-internally Signals that a given pull request has been imported internally. label Mar 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoeLoser JoeLoser JoeLoser approved these changes

Assignees

@JoeLoser JoeLoser

Labels
imported-internally Signals that a given pull request has been imported internally.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@soraros @JoeLoser @modularbot