Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stdlib] Simplify bit.mojo #4210

Closed
wants to merge 1 commit into from
Closed

[stdlib] Simplify bit.mojo #4210

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 2 additions & 5 deletions mojo/stdlib/src/bit/bit.mojo
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,9 +81,7 @@ fn count_trailing_zeros(val: Int) -> Int:
Returns:
The number of trailing zeros of the input.
"""
return llvm_intrinsic[
"llvm.cttz", __mlir_type.index, has_side_effect=False
](val.value, False.value)
return llvm_intrinsic["llvm.cttz", Int, has_side_effect=False](val, False)


@always_inline("nodebug")
Expand Down Expand Up @@ -284,8 +282,7 @@ fn bit_not[
NOT of the integer value at position `i` of the input value.
"""
constrained[type.is_integral(), "must be integral"]()
var neg_one = SIMD[type, width](-1)
return __mlir_op.`pop.simd.xor`(val.value, neg_one.value)
return ~val


# ===-----------------------------------------------------------------------===#
Expand Down