Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add oidc claim debugging #82

Closed
wants to merge 4 commits into from
Closed

add oidc claim debugging #82

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ad3ed75
add oidc claim debugging
mnbf9rca Sep 12, 2024
65feb79
add github token
mnbf9rca Sep 12, 2024
f88fd12
fix not deploying to test
mnbf9rca Sep 12, 2024
2c2c582
add audience to debug
mnbf9rca Sep 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 10 additions & 5 deletions .github/workflows/deploy_to_pypi.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,16 @@ jobs:
environment:
name: ${{ inputs.target-environment }}
steps:
- name: Checkout actions-oidc-debugger
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚨 suggestion (security): Consider documenting the use of the OIDC debugger and its security implications.

While adding debugging capabilities can be helpful, it's important to document why this OIDC debugger is necessary and consider any potential security risks. Consider adding a comment explaining its purpose and ensure that it's only used in non-production environments. Also, review the information being logged to prevent accidental exposure of sensitive data. On a positive note, good job on removing the commented-out code for version extraction, which helps keep the codebase clean.

uses: actions/checkout@v3
with:
repository: github/actions-oidc-debugger
ref: main
token: ${{ secrets.your-checkout-token }}
path: ./.github/actions/actions-oidc-debugger
- name: Debug OIDC Claims
uses: ./.github/actions/actions-oidc-debugger

- name: get workspacedir
# see https://github.com/actions/runner/issues/2058#issuecomment-1308554566
shell: bash
Expand All @@ -40,11 +50,6 @@ jobs:
- name: show files
run: |
find ${{ env.GITHUB_WORKSPACE }}/dist -type f
# - name: extract version from pyproject.toml
# run: |
# version=$(grep 'version =' pyproject.toml | awk '{print $3}' | sed 's/"//g')
# echo "VERSION=$version" >> $GITHUB_ENV
# echo "extracted version '{{ $env.VERSION }}' from pyproject.toml"
- name: Publish package distributions to ${{ inputs.target-environment }}
uses: pypa/gh-action-pypi-publish@release/v1
with:
Expand Down
Loading