Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unpin digests, autoclose renovate PRs #75

Merged
merged 6 commits into from
Aug 15, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions .github/workflows/deploy_build_artifact.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -29,19 +29,19 @@ jobs:


- name: Set up Python
uses: actions/setup-python@39cd14951b08e74b54015e9e001cdefcf80e669f # v5
uses: actions/setup-python@v5 # v5
with:
python-version: 3.12

- name: install poetry
uses: snok/install-poetry@93ada01c735cc8a383ce0ce2ae205a21c415379b # v1
uses: snok/install-poetry@v1 # v1
with:
version: 1.8.3 # pin the version as they keep changing their APIs
virtualenvs-create: false
virtualenvs-in-project: false

- name: check out code
uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332 # v4
uses: actions/checkout@v4 # v4
with:
fetch-depth: 1

Expand Down Expand Up @@ -78,7 +78,7 @@ jobs:

- name: Upload build artifact
id: upload-artifact
uses: actions/upload-artifact@0b2256b8c012f0828dc542b3febcab082c67f72b # v4
uses: actions/upload-artifact@v4 # v4
with:
compression-level: 0 # no compression
if-no-files-found: error
Expand Down
8 changes: 4 additions & 4 deletions .github/workflows/deploy_bump_version.yml
Original file line number Diff line number Diff line change
Expand Up @@ -42,26 +42,26 @@ jobs:
echo "BUMP_TYPE=patch" >> "$GITHUB_ENV"
fi
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion: Consider simplifying bump type determination logic

The current if-else structure for determining the bump type could be simplified using a case statement or a mapping. This would make the code more concise and easier to maintain, especially if more bump types are added in the future.

Suggested change
fi
case "${{ github.event.pull_request.labels.*.name }}" in
*"bump:major"*) echo "BUMP_TYPE=major" >> "$GITHUB_ENV" ;;
*"bump:minor"*) echo "BUMP_TYPE=minor" >> "$GITHUB_ENV" ;;
*) echo "BUMP_TYPE=patch" >> "$GITHUB_ENV" ;;
esac

- name: Create GitHub App Token
uses: actions/create-github-app-token@31c86eb3b33c9b601a1f60f98dcbfd1d70f379b4 # v1
uses: actions/create-github-app-token@v1 # v1
# Create GitHub App Token to let us push changes to main
id: app-token
with:
app-id: ${{ vars.PUSH_APP_ID }}
private-key: ${{ secrets.PUSH_APP_SECRET }}

- name: check out code
uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332 # v4
uses: actions/checkout@v4 # v4
with:
fetch-depth: 0
token: ${{ steps.app-token.outputs.token }}

- name: Set up Python
uses: actions/setup-python@39cd14951b08e74b54015e9e001cdefcf80e669f # v5
uses: actions/setup-python@v5 # v5
with:
python-version: 3.12

- name: install poetry
uses: snok/install-poetry@93ada01c735cc8a383ce0ce2ae205a21c415379b # v1
uses: snok/install-poetry@v1 # v1
with:
version: 1.8.3 # pin the version as they keep changing their APIs
virtualenvs-create: false
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/deploy_to_pypi.yml
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ jobs:
echo "GITHUB_WORKSPACE=$GITHUB_WORKSPACE" >> $GITHUB_ENV
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion: Use built-in GitHub context for workspace path

Instead of setting the GITHUB_WORKSPACE as an environment variable, consider using the built-in ${{ github.workspace }} context variable directly. This ensures consistency and avoids potential issues with environment variable scope.

Suggested change
echo "GITHUB_WORKSPACE=$GITHUB_WORKSPACE" >> $GITHUB_ENV
- name: Set workspace path
run: echo "WORKSPACE=${{ github.workspace }}" >> $GITHUB_ENV

- name: download artifact from previous run
id: download-artifact
uses: actions/download-artifact@fa0a91b85d4f404e444e00e005971372dc801d16 # v4
uses: actions/download-artifact@v4 # v4
with:
name: ${{ inputs.artifact-name }}
path: ${{ env.GITHUB_WORKSPACE }}/dist
Expand Down
14 changes: 8 additions & 6 deletions .github/workflows/test_close_pr.yaml
Original file line number Diff line number Diff line change
@@ -1,22 +1,24 @@
name: Close Renovate PRs on Success

on:
workflow_run:
workflows: ["Run Tests"]
types:
- completed
workflow_call:
inputs:
pull_requests:
type: string
required: true
description: 'The pull requests to close'

jobs:
close_pr:
if: ${{ github.event.workflow_run.conclusion == 'success' }}
runs-on: ubuntu-latest
steps:
- name: Checkout code
uses: actions/checkout@v2
uses: actions/checkout@v4

- name: Close PR if tests pass and label exists
run: |
PR_NUMBER=$(jq -r '.pull_requests[0].number' < "${{ github.event.workflow_run.pull_requests }}")
PR_NUMBER=$(jq -r '.pull_requests[0].number' <<< "${{ inputs.pull_requests }}")
LABELS=$(gh pr view $PR_NUMBER --json labels --jq '.labels[].name')
if [[ "$LABELS" == *"renovate-pydantic-requests"* ]]; then
gh pr close $PR_NUMBER --delete-branch
Expand Down
8 changes: 4 additions & 4 deletions .github/workflows/test_codeql.yml
Original file line number Diff line number Diff line change
Expand Up @@ -39,11 +39,11 @@ jobs:

steps:
- name: Checkout repository
uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332 # v4
uses: actions/checkout@v4 # v4

# Initializes the CodeQL tools for scanning.
- name: Initialize CodeQL
uses: github/codeql-action/init@2d790406f505036ef40ecba973cc774a50395aac # v3
uses: github/codeql-action/init@v3 # v3
with:
languages: ${{ matrix.language }}
# If you wish to specify custom queries, you can do so here or in a config file.
Expand All @@ -56,7 +56,7 @@ jobs:
# Autobuild attempts to build any compiled languages (C/C++, C#, Go, or Java).
# If this step fails, then you should remove it and run the build manually (see below)
- name: Autobuild
uses: github/codeql-action/autobuild@2d790406f505036ef40ecba973cc774a50395aac # v3
uses: github/codeql-action/autobuild@v3 # v3

# ℹ️ Command-line programs to run using the OS shell.
# 📚 See https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#jobsjob_idstepsrun
Expand All @@ -69,6 +69,6 @@ jobs:
# ./location_of_script_within_repo/buildscript.sh

- name: Perform CodeQL Analysis
uses: github/codeql-action/analyze@2d790406f505036ef40ecba973cc774a50395aac # v3
uses: github/codeql-action/analyze@v3 # v3
with:
category: "/language:${{matrix.language}}"
4 changes: 2 additions & 2 deletions .github/workflows/test_dependency_review.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,6 @@ jobs:
runs-on: ubuntu-latest
steps:
- name: 'Checkout Repository'
uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332 # v4
uses: actions/checkout@v4 # v4
- name: 'Dependency Review'
uses: actions/dependency-review-action@5a2ce3f5b92ee19cbb1541a4984c76d921601d7c # v4
uses: actions/dependency-review-action@v4 # v4
6 changes: 3 additions & 3 deletions .github/workflows/test_run_pytest.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,12 +18,12 @@ jobs:
python-version: ["3.10", "3.11", "3.12"]
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332 # v4
- uses: actions/checkout@v4 # v4
- name: Set up Python ${{ matrix.python-version }}
uses: actions/setup-python@39cd14951b08e74b54015e9e001cdefcf80e669f # v5
uses: actions/setup-python@v5 # v5
with:
python-version: ${{ matrix.python-version }}
- uses: snok/install-poetry@93ada01c735cc8a383ce0ce2ae205a21c415379b # v1
- uses: snok/install-poetry@v1 # v1
with:
version: 1.8.3 # pin the version as they keep changing their APIs
virtualenvs-create: false
Expand Down
6 changes: 6 additions & 0 deletions .github/workflows/test_workflow_wrapper.yml
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,12 @@ jobs:
dependencies:
uses: ./.github/workflows/test_dependency_review.yml

# close PR if tests pass and label exists
close_pr:
needs: [test]
uses: ./.github/workflows/test_close_pr.yaml
with:
pull_requests: ${{ github.event.pull_request }}

# bump_version:
# needs: [codeql, test]
Expand Down
Loading