-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
unpin digests, autoclose renovate PRs #75
Conversation
Reviewer's Guide by SourceryThis pull request focuses on updating GitHub Actions workflows by unpinning digest versions and replacing them with semantic versioning. It also introduces a new workflow to automatically close Renovate PRs upon successful tests. The changes aim to improve maintainability and automate certain processes in the CI/CD pipeline. File-Level Changes
Tips
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @mnbf9rca - I've reviewed your changes - here's some feedback:
Overall Comments:
- Could you provide some context in the PR description about the motivation for moving from pinned commit hashes to version tags for GitHub Actions?
- Consider adding or updating documentation about the workflow changes, particularly the new PR auto-closing feature, to help other contributors understand the CI/CD process.
Here's what I looked at during the review
- 🟡 General issues: 2 issues found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.
@@ -42,26 +42,26 @@ jobs: | |||
echo "BUMP_TYPE=patch" >> "$GITHUB_ENV" | |||
fi |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggestion: Consider simplifying bump type determination logic
The current if-else structure for determining the bump type could be simplified using a case statement or a mapping. This would make the code more concise and easier to maintain, especially if more bump types are added in the future.
fi | |
case "${{ github.event.pull_request.labels.*.name }}" in | |
*"bump:major"*) echo "BUMP_TYPE=major" >> "$GITHUB_ENV" ;; | |
*"bump:minor"*) echo "BUMP_TYPE=minor" >> "$GITHUB_ENV" ;; | |
*) echo "BUMP_TYPE=patch" >> "$GITHUB_ENV" ;; | |
esac |
@@ -33,7 +33,7 @@ jobs: | |||
echo "GITHUB_WORKSPACE=$GITHUB_WORKSPACE" >> $GITHUB_ENV |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggestion: Use built-in GitHub context for workspace path
Instead of setting the GITHUB_WORKSPACE as an environment variable, consider using the built-in ${{ github.workspace }} context variable directly. This ensures consistency and avoids potential issues with environment variable scope.
echo "GITHUB_WORKSPACE=$GITHUB_WORKSPACE" >> $GITHUB_ENV | |
- name: Set workspace path | |
run: echo "WORKSPACE=${{ github.workspace }}" >> $GITHUB_ENV |
Summary by Sourcery
Update GitHub Actions workflows to use version tags instead of specific commit hashes for actions, and enhance the 'Close Renovate PRs on Success' workflow to use 'workflow_call' with inputs for improved flexibility.
CI: