Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚸 improve fig loading overlay to only show on img change #44

Merged
merged 1 commit into from
Jul 14, 2023

Conversation

danton267
Copy link
Collaborator

Now the overlay will only display when the project is changed or when the image layer is changed

Note dmc.LoadingOverlay does not have disabled so I just change its zIndex

@danton267 danton267 self-assigned this Jul 14, 2023
@danton267 danton267 linked an issue Jul 14, 2023 that may be closed by this pull request
@github-actions
Copy link

Staging application has been deployed and is available at: https://dash5-services.plotly.host/ml-exchange-staging
Production app name: ml-exchange
Current branch name: fix-loading-overlay
Commit: 9ebafde

@hannahker hannahker self-requested a review July 14, 2023 19:19
Copy link
Collaborator

@hannahker hannahker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hacky, but it works! 💃

@hannahker hannahker merged commit 0f71cea into main Jul 14, 2023
4 checks passed
@hannahker hannahker deleted the fix-loading-overlay branch July 14, 2023 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve loading spinner UI
2 participants