Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve loading spinner UI #40

Closed
hannahker opened this issue Jul 13, 2023 · 0 comments · Fixed by #44
Closed

Improve loading spinner UI #40

hannahker opened this issue Jul 13, 2023 · 0 comments · Fixed by #44
Assignees
@danton267
Labels
bug Something isn't working
Milestone
Prototype App

Comments

@hannahker
Copy link
Collaborator

The loading spinner displays on the chart when the user toggles the annotations on/off, and when the user selects a new annotation mode button. Can we remove the loading spinner during these actions, but preserve it when the user requests a new image (via the top slider or top left dropdown)?
@hannahker hannahker added the bug Something isn't working label Jul 13, 2023
@hannahker hannahker added this to the Prototype App milestone Jul 13, 2023
@danton267 danton267 self-assigned this Jul 13, 2023
@danton267 danton267 linked a pull request Jul 14, 2023 that will close this issue
🚸 improve fig loading overlay to only show on img change #44
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@danton267 danton267

Labels
bug Something isn't working
Projects
None yet
Milestone
Prototype App
Development

Successfully merging a pull request may close this issue.

🚸 improve fig loading overlay to only show on img change mlexchange/mlex_highres_segmentation
2 participants
@hannahker @danton267