Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cross slice annotation saving #32

Merged
merged 2 commits into from
Jul 13, 2023
Merged

Cross slice annotation saving #32

merged 2 commits into from
Jul 13, 2023

Conversation

danton267
Copy link
Collaborator

@danton267 danton267 commented Jul 13, 2023 •
edited
Loading

This PR adds

  • saving annotations across image slices
  • saves visibility of annotations across slices
  • saves dragmode (drawing) across slices
  • disables dragmode (drawing) if the visibility of annotations is set to hidden

addresses #29 and it also fixes #19

@github-actions
Copy link

Staging application has been deployed and is available at: https://dash5-services.plotly.host/ml-exchange-staging
Production app name: ml-exchange
Current branch name: cross-slice-annotation-saving
Commit: ca2fc56

@danton267 danton267 requested a review from hannahker July 13, 2023 11:20
danton267
danton267 commented Jul 13, 2023
View reviewed changes
callbacks/image_viewer.py
@@ -42,24 +43,58 @@ def render_image(
hex_color = dmc.theme.DEFAULT_COLORS[annotation_color][7]
fig.update_layout(
newshape=dict(
line=dict(color=annotation_color, width=annotation_width),
line=dict(
color=convert_hex_to_rgba(hex_color, 0.3), width=annotation_width
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

adressess #19

@danton267 danton267 mentioned this pull request Jul 13, 2023
Closed
2 tasks
@danton267 danton267 linked an issue Jul 13, 2023 that may be closed by this pull request
Index annotations according to a given image slice #29
Closed
2 tasks
@hannahker hannahker requested a review from tamidodo July 13, 2023 19:19
tamidodo
tamidodo approved these changes Jul 13, 2023
View reviewed changes
Copy link
Contributor

@tamidodo tamidodo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Tested locally and the saving of annotations works, good call on maintaining the selected annotation mode when you switch images

@tamidodo tamidodo merged commit 609714d into main Jul 13, 2023
4 checks passed
@tamidodo tamidodo deleted the cross-slice-annotation-saving branch July 13, 2023 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tamidodo tamidodo tamidodo approved these changes

@hannahker hannahker Awaiting requested review from hannahker

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Index annotations according to a given image slice grape color is invalid for Plotly chart
2 participants
@danton267 @tamidodo