Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Index annotations according to a given image slice #29

Closed
2 tasks
hannahker opened this issue Jul 11, 2023 · 1 comment · Fixed by #32
Closed
2 tasks

Index annotations according to a given image slice #29

hannahker opened this issue Jul 11, 2023 · 1 comment · Fixed by #32
Assignees
Labels
bug Something isn't working
Milestone

Comments

@hannahker
Copy link
Collaborator

A given annotation should only correspond to the image slice where it was drawn.

  • Annotations should not persist when someone slices across images
  • When the user comes back to a given slice, they should see any annotations that they previously added for that slice, provided the "view annotation layer" is turned on

We have this logic in progress, but it feels buggy when I'm testing the app as I often get KeyErrors like this:

Traceback (most recent call last):
  File "/Users/hannahker/Desktop/mlex/mlex_highres_segmentation/callbacks/control_bar.py", line 60, in annotation_visibility
    patched_figure["layout"]["shapes"] = store[image_idx]
KeyError: '1'
@hannahker hannahker added bug Something isn't working prototype To be included in the initial prototype labels Jul 11, 2023
@danton267 danton267 self-assigned this Jul 13, 2023
@danton267
Copy link
Collaborator

addressed in #32

@danton267 danton267 linked a pull request Jul 13, 2023 that will close this issue
@hannahker hannahker added bug Something isn't working and removed bug Something isn't working prototype To be included in the initial prototype labels Jul 13, 2023
@hannahker hannahker added this to the Prototype App milestone Jul 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants