Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix][Vite] Fix error for index.js.map #420

Merged
merged 1 commit into from
May 25, 2024
Merged

[Fix][Vite] Fix error for index.js.map #420

merged 1 commit into from
May 25, 2024

Conversation

felladrin
Copy link
Contributor

@felladrin felladrin commented May 24, 2024

This PR escapes the MLC_DUMMY_PATH variable the same way it was done with MLC_DUMMY_REQUIRE_VAR in #415.

P.S. I edited the file directly in GitHub UI, and it automatically added a line break in the last line of the file. It was not intentional.

- Follow-up from #415
- Fixes #414

This PR escapes the `MLC_DUMMY_PATH` variable the same way it was done with `MLC_DUMMY_REQUIRE_VAR` in #415.
@tqchen tqchen merged commit 9e31033 into mlc-ai:main May 25, 2024
CharlieFRuan added a commit that referenced this pull request May 30, 2024
### Changes
Main changes include:
- New prebuilt models:
  - Phi3-mini
  - StableLM-2-zephyr-1.6B
  - Qwen1.5-1.8B
  - Hermes2-Pro-Llama-3-8B to prebuilt models
- Updates on `ModelRecord` fields
  - For detail see: #435
- Update all WASMs
  - For detail see: #433
  - Update all WASMs to v0.2.39
- Support grammar for Llama3, hence update examples/json-mode to use
`Llama3` and `Hermes2-pro-Llama3-8B` for function calling in
`examples/json-schema`
- Use `loglevel` package:
  - For details see #427
- Fix `index.js.map` issue for Vite
  - #420
- Enhance error handling and ServiceWorker

### TVMjs
TVMjs compiled at
apache/tvm@71f7af7
- Main changes include: 
  - apache/tvm#17031
  - apache/tvm#17028
  - apache/tvm#17021

### WASM version
- All wasms updated to 0.2.39 via
mlc-ai/binary-mlc-llm-libs#123 for new MLC-LLM
runtime (mainly grammar)
CharlieFRuan added a commit that referenced this pull request May 31, 2024
This PR fixes `\"` issue in `index.js.map`, which breaks Vite
deployment, follows the thread
#414

This PR undoes the change in `cleanup-index-js.sh` to `index.js` in
#420, and update `"` to `'` for
`index.js.map`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issue with source map in v0.2.37 when running with Vite
2 participants