-
Notifications
You must be signed in to change notification settings - Fork 871
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue with source map in v0.2.37 when running with Vite #414
Comments
Thanks for reporting the error, will send a fix soon |
Address issue #414. Since `index.js.map` is a json, when specifying string, we should use `\"` instead of `"`. Prior to this PR, we populate `const performanceNode = "MLC_DUMMY_REQUIRE_VAR"`, this PR changes it to `const performanceNode = \"MLC_DUMMY_REQUIRE_VAR\"`
### Changes The only two changes are: - #413 - #415 - Fixes `index.js.map` issue in Vite reported in #414 ### WASM Version v0_2_34 as no change is required. ### TVMjs TVMjs compiled at apache/tvm@a5862a5, with no change
Could you try 0.2.38? Should be fixed via #415. Apologies for the inconvenience |
Thanks for the quick response, @CharlieFRuan! I've installed v0.2.38 and noticed a difference already, but now the error is in another place of I've manually replaced all occurrences of |
Sorry, @CharlieFRuan and @tqchen, I also double-checked it on https://www.npmjs.com/package/@mlc-ai/web-llm?activeTab=code and we can see the issue is there on Can we re-open this issue, and could you confirm why the change on #420 didn't fix it? |
Ahh thanks for the catch; this should be due to how we need |
Could you try 0.2.40 which includes #440? |
Thank you! Now it's fixed! 🎉 Confirmed here: And also by removing the workaround I had for the issue. |
When running the project with Vite, it's throwing this error:
(It doesn't prevent Vite from running, it's just annoying)
Temporary solution: remove the
//# sourceMappingURL=index.js.map
line from@mlc-ai/web-llm/lib/index.js
before compiling and Vite won't throw any errors.Extra info: The v0.2.35 didn't have this problem.
The text was updated successfully, but these errors were encountered: