Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue/rmgr #273

Merged
merged 8 commits into from
Jan 14, 2025
Merged

Issue/rmgr #273

merged 8 commits into from
Jan 14, 2025

Conversation

muthumala19
Copy link
Contributor

Fix local store file deletion issue for rmgr command.

Copy link

codecov bot commented Jan 12, 2025

Codecov Report

Attention: Patch coverage is 0% with 44 lines in your changes missing coverage. Please review.

Project coverage is 1.34%. Comparing base (0f994cf) to head (1ee92ef).
Report is 9 commits behind head on master.

Files with missing lines Patch % Lines
src/util/Utils.cpp 0.00% 36 Missing ⚠️
src/server/JasmineGraphInstanceService.cpp 0.00% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##           master    #273      +/-   ##
=========================================
- Coverage    1.34%   1.34%   -0.01%     
=========================================
  Files          77      77              
  Lines       15389   15432      +43     
  Branches     9808    9839      +31     
=========================================
  Hits          207     207              
- Misses      14978   15021      +43     
  Partials      204     204              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

src/util/Utils.cpp Outdated Show resolved Hide resolved
src/util/Utils.cpp Outdated Show resolved Hide resolved
src/util/Utils.cpp Outdated Show resolved Hide resolved
Copy link
Owner

@miyurud miyurud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have put some comments. Please address them all and explain for each comment how you addressed them.

Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
B Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@miyurud miyurud merged commit 5538e94 into miyurud:master Jan 14, 2025
6 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants