-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix rmgr command issue #272
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #272 +/- ##
=========================================
- Coverage 1.34% 1.31% -0.03%
=========================================
Files 77 77
Lines 15389 15431 +42
Branches 9808 9838 +30
=========================================
- Hits 207 203 -4
- Misses 14978 15027 +49
+ Partials 204 201 -3 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have put some comments. Please address them all and explain for each comment how you addressed them.
Co-authored-by: Miyuru Dayarathna <[email protected]>
Co-authored-by: Miyuru Dayarathna <[email protected]>
Co-authored-by: Miyuru Dayarathna <[email protected]>
Co-authored-by: Miyuru Dayarathna <[email protected]>
Quality Gate failedFailed conditions See analysis details on SonarQube Cloud Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE |
closing this PR due to opening a new PR (#273) |
Fix local store file deletion issue for rmgr command.