Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Database Binaries & Create Database with DDL #232

Merged
merged 5 commits into from
Jan 25, 2024

Conversation

Ishad-M-I-M
Copy link
Collaborator

No description provided.

Copy link

codecov bot commented Jan 21, 2024

Codecov Report

Attention: 28 lines in your changes are missing coverage. Please review.

Comparison is base (daeda1c) 1.05% compared to head (cbd27c3) 1.19%.

❗ Current head cbd27c3 differs from pull request most recent head 92786d8. Consider uploading reports for the commit 92786d8 to get more accurate results

Files Patch % Lines
src/util/Utils.cpp 14.28% 7 Missing and 11 partials ⚠️
src/performancedb/PerformanceSQLiteDBInterface.cpp 30.00% 4 Missing and 3 partials ⚠️
src/metadb/SQLiteDBInterface.cpp 0.00% 1 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##           master    #232      +/-   ##
=========================================
+ Coverage    1.05%   1.19%   +0.14%     
=========================================
  Files          61      61              
  Lines       13938   13970      +32     
  Branches     8881    8901      +20     
=========================================
+ Hits          147     167      +20     
+ Misses      13656   13645      -11     
- Partials      135     158      +23     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Owner

@miyurud miyurud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Ishad-M-I-M Ishad-M-I-M force-pushed the remove-binaries branch 2 times, most recently from d6ad22f to cbd27c3 Compare January 25, 2024 04:58
Copy link

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

19 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@miyurud miyurud merged commit 8492849 into miyurud:master Jan 25, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants