Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial version of streaming triangle counting #229

Merged
merged 12 commits into from
Jan 26, 2024

Conversation

Ashok12011234
Copy link
Contributor

No description provided.

Copy link

codecov bot commented Jan 18, 2024

Codecov Report

Attention: 1058 lines in your changes are missing coverage. Please review.

Comparison is base (8492849) 1.24% compared to head (9c209f2) 1.17%.

Files Patch % Lines
...e/executor/impl/StreamingTriangleCountExecutor.cpp 0.00% 403 Missing ⚠️
src/server/JasmineGraphInstanceService.cpp 0.00% 164 Missing ⚠️
.../query/algorithms/triangles/StreamingTriangles.cpp 0.00% 137 Missing ⚠️
src/streamingdb/StreamingSQLiteDBInterface.cpp 0.00% 99 Missing ⚠️
src/frontend/JasmineGraphFrontEnd.cpp 0.00% 65 Missing ⚠️
src/nativestore/NodeManager.cpp 0.00% 44 Missing ⚠️
src/nativestore/NodeBlock.cpp 0.00% 43 Missing ⚠️
src/nativestore/RelationBlock.cpp 0.00% 40 Missing ⚠️
src/query/algorithms/triangles/Triangles.cpp 0.00% 27 Missing ⚠️
src/frontend/core/executor/AbstractExecutor.cpp 0.00% 23 Missing ⚠️
... and 3 more
Additional details and impacted files
@@            Coverage Diff            @@
##           master    #229      +/-   ##
=========================================
- Coverage    1.24%   1.17%   -0.08%     
=========================================
  Files          61      64       +3     
  Lines       13970   14814     +844     
  Branches     8901    9455     +554     
=========================================
  Hits          174     174              
- Misses      13628   14472     +844     
  Partials      168     168              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Ishad-M-I-M
Copy link
Collaborator

Instead of adding jasminegraph_streaming.db binary, let's follow the same method use in #232 for create the sqlite database.
It'll make it easier to handle the schema changes.

Copy link
Owner

@miyurud miyurud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have put some initial comments. Those seems to be repeating again an again. Hence lets get those fixed first.

Copy link

Quality Gate Failed Quality Gate failed

Failed conditions

2 Security Hotspots
10.3% Duplication on New Code (required ≤ 3%)
D Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

idea Catch issues before they fail your Quality Gate with our IDE extension SonarLint SonarLint

@miyurud miyurud merged commit 91460bb into miyurud:master Jan 26, 2024
3 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants