Skip to content

removing order from InstructorPageLink #2520

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jan 30, 2025
Merged

removing order from InstructorPageLink #2520

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
5fd7532
removing order
annagav Jan 29, 2025
56d474f
order doesn't work
annagav Jan 30, 2025
0b70a3d
I think it works fine
annagav Jan 30, 2025
3af8f64
remove import
annagav Jan 30, 2025
3faf712
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Jan 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions cms/models.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1102,7 +1102,10 @@ def is_program_page(self):
FieldPanel("feature_image"),
FieldPanel("video_url"),
FieldPanel("faculty_section_title"),
InlinePanel("linked_instructors", label="Faculty Members"),
InlinePanel(
"linked_instructors",
label="Faculty Members",
),
]

subpage_types = ["FlexiblePricingRequestForm", "CertificatePage"]
Expand Down Expand Up @@ -1139,8 +1142,7 @@ def get_url_parts(self, request=None):

def get_context(self, request, *args, **kwargs): # noqa: ARG002
instructors = [
member.linked_instructor_page
for member in self.linked_instructors.order_by("order").all()
member.linked_instructor_page for member in self.linked_instructors.all()
]

return {
Expand Down