removing order from InstructorPageLink #2520
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
annagav
force-pushed
the
ag/faculty_order
branch
from
6e02801 to
5fd7532
Compare
annagav
force-pushed
the
ag/faculty_order
branch
from
8ac5c30 to
56d474f
Compare
annagav
force-pushed
the
ag/faculty_order
branch
from
32532cf to
0b70a3d
Compare
annagav
force-pushed
the
ag/faculty_order
branch
from
72d08aa to
3af8f64
Compare
for more information, see https://pre-commit.ci
|
Sorry, I don't understand. Does this make the order of instructors follow the order in the CMS? |
|
yes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are the relevant tickets?
fix https://github.com/mitodl/hq/issues/6415
Description (What does it do?)
Removing the ordering of instructor link page. It doesn't do anything useful.
When the admin re-chooses instructors the order is unpredictable, or at least was unpredictable.
How can this be tested?
Go to cms page. Start editing a course page by adding a bunch of instructors to the page. Check the order on the page.
Then go ahead and change some of the selection to another instructor. Check the order of instructors on the page again. (this used to mess up the order)
Then try deleting and adding them in the desired order.
Check that the order is as expected.