-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
primer_view_components を導入 #564
Open
YutaGoto
wants to merge
35
commits into
main
Choose a base branch
from
add-primer_view_components
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 32 commits
Commits
Show all changes
35 commits
Select commit
Hold shift + click to select a range
6c5dbe0
primer_view_componentsを追加
YutaGoto d0b8d1e
primer/view_components の初期設定
YutaGoto ca74328
LoginFormクラスを実装
YutaGoto 2c68713
FlashメッセージをPrimerに置換する
YutaGoto 1882d50
Loginフォームを再実装
YutaGoto 164d90b
flashタイプの修正
YutaGoto 9028dcb
Merge branch 'main' into add-primer_view_components
YutaGoto 9823138
primer_view_componentsをアップグレード
YutaGoto f01b4ab
header menuのレイアウトを調整
YutaGoto 21ed721
flashメッセージのコンポーネントを置き換え
YutaGoto 1692746
ログインフォームのコンポーネントを修正
YutaGoto 71e24eb
Merge branch 'main' into add-primer_view_components
YutaGoto 9b1ab53
spec: componentテストを修正
YutaGoto ca47bd8
feat: イベント一覧ページのスタイル修正
YutaGoto 05794f2
Merge branch 'main' into add-primer_view_components
YutaGoto d962b2f
Merge branch 'main' into add-primer_view_components
YutaGoto 89a78c3
feat: SignupFormを実装
YutaGoto 12129b2
feat: EventFormを実装
YutaGoto 5c08bb4
Merge branch 'main' into add-primer_view_components
YutaGoto 0e25b51
update primer_view_components
YutaGoto aa791ca
adapt primer for event show page
YutaGoto 4b6fc06
fix for layout
YutaGoto 100b80d
Merge branch 'main' into add-primer_view_components
YutaGoto a166b9c
bootstrap gemを削除
YutaGoto 16270d2
FlashではなくBannerを使用するように変更
YutaGoto 79d9254
Merge branch 'main' into add-primer_view_components
YutaGoto c84496e
system specのボタン文言などを修正
YutaGoto 5886ba0
ciのテストを修正
YutaGoto 644f41d
Merge branch 'main' into add-primer_view_components
YutaGoto 67eefff
fix: bootstrapを削除
YutaGoto 2647fc2
Merge branch 'main' into add-primer_view_components
YutaGoto 1538de3
Merge branch 'main' into add-primer_view_components
YutaGoto 9345e33
AppliationFormでtypoしていたので、ApplicationFormに修正
greendrop f46341c
Merge branch 'main' into add-primer_view_components
YutaGoto 908be19
primer view componentのバージョンアップ
YutaGoto File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,4 @@ | ||
// Entry point for your Sass build | ||
|
||
@import "./application.bootstrap.scss" | ||
//= link primer_view_components.css | ||
@import url("https://unpkg.com/@primer/css@^21.1.1/dist/primer.css") |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1 @@ | ||
<% alert_name = @message_type.to_sym == :alert ? 'danger' : 'success' %> | ||
<div class="alert alert-<%= alert_name %>"> | ||
<%= @message %> | ||
</div> | ||
<%= render(Primer::Alpha::Banner.new(scheme: @message_type)) { @message } %> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,2 @@ | ||
class ApplicationForm < Primer::Forms::Base | ||
end |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,56 @@ | ||
class EventForm < ApplicationForm | ||
form do |event_form| | ||
event_form.text_field( | ||
name: :name, | ||
type: "text", | ||
label: 'タイトル', | ||
required: true, | ||
) | ||
|
||
event_form.text_field( | ||
name: :description, | ||
type: "text", | ||
label: '説明', | ||
required: true, | ||
) | ||
|
||
event_form.text_field( | ||
name: :location, | ||
type: "text", | ||
label: '場所', | ||
) | ||
|
||
event_form.text_field( | ||
name: :max_size, | ||
type: "number", | ||
label: '最大人数', | ||
) | ||
|
||
event_form.text_field( | ||
name: :budget, | ||
type: "text", | ||
label: '予算', | ||
) | ||
|
||
event_form.text_field( | ||
name: :start_at, | ||
type: "datetime-local", | ||
label: '開始日時', | ||
required: true, | ||
) | ||
|
||
event_form.text_field( | ||
name: :end_at, | ||
type: "datetime-local", | ||
label: '終了日時', | ||
required: true, | ||
) | ||
|
||
event_form.submit( | ||
name: :submit, | ||
label: "登録", | ||
scheme: :primary, | ||
mb: 3 | ||
) | ||
end | ||
end |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,24 @@ | ||
class LoginForm < ApplicationForm | ||
form do |login_form| | ||
login_form.text_field( | ||
name: :email, | ||
type: "email", | ||
label: 'メールアドレス', | ||
required: true, | ||
) | ||
|
||
login_form.text_field( | ||
name: :password, | ||
type: "password", | ||
label: 'パスワード', | ||
required: true, | ||
) | ||
|
||
login_form.submit( | ||
name: :submit, | ||
label: 'ログイン', | ||
scheme: :primary, | ||
mb: 3 | ||
) | ||
end | ||
end |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ファイル名がtypoしているので、CIが失敗しているかもしれません
app/forms/appliation_form.rb
app/forms/application_form.rb
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
なるほどなるほど!!!ありがとうございます!!! 🙇🙇🙇🙇🙇🙇