Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

primer_view_components を導入 #564

Open
wants to merge 35 commits into
base: main
Choose a base branch
from
Open

Conversation

YutaGoto
Copy link
Member

@YutaGoto YutaGoto commented Oct 15, 2023

@tatsuosakurai tatsuosakurai force-pushed the add-primer_view_components branch from 3f8be12 to 164d90b Compare November 16, 2023 12:08
@YutaGoto YutaGoto marked this pull request as ready for review February 12, 2024 07:31
@YutaGoto YutaGoto self-assigned this Feb 12, 2024
Copy link
Contributor

@greendrop greendrop Jun 13, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ファイル名がtypoしているので、CIが失敗しているかもしれません

  • 誤: app/forms/appliation_form.rb
  • 正: app/forms/application_form.rb
Zeitwerk::NameError:
  expected file /home/runner/work/beerkeeper/beerkeeper/app/forms/appliation_form.rb to define constant AppliationForm, but didn't

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

なるほどなるほど!!!ありがとうございます!!! 🙇🙇🙇🙇🙇🙇

@tatsuosakurai
Copy link
Collaborator

@YutaGoto
Copy link
Member Author

npm packageいれます?

@dlwr dlwr requested a review from Copilot December 12, 2024 12:10

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 16 out of 31 changed files in this pull request and generated no suggestions.

Files not reviewed (15)
  • app/assets/stylesheets/application.bootstrap.scss: Language not supported
  • app/assets/stylesheets/application.scss: Language not supported
  • app/views/events/_form.erb: Evaluated as low risk
  • app/views/events/show.html.erb: Evaluated as low risk
  • app/components/alert_component.html.erb: Evaluated as low risk
  • app/views/events/new.html.erb: Evaluated as low risk
  • app/views/events/index.html.erb: Evaluated as low risk
  • app/views/events/edit.html.erb: Evaluated as low risk
  • app/forms/event_form.rb: Evaluated as low risk
  • app/forms/application_form.rb: Evaluated as low risk
  • Gemfile: Evaluated as low risk
  • app/forms/login_form.rb: Evaluated as low risk
  • app/forms/participant_form.rb: Evaluated as low risk
  • app/forms/signup_form.rb: Evaluated as low risk
  • app/javascript/application.js: Evaluated as low risk
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants